Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing methods for renderer context menu so tests can run. #4673

Closed
wants to merge 1 commit into from

Conversation

jonathanKingston
Copy link
Contributor

Resolves brave/brave-browser#8297

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jonathanKingston
Copy link
Contributor Author

I tried to find a solution that created less diff noise but I don't think there is anything obvious here.

An alternative perhaps would be just to inject in all of the Brave code into the Chromium version rather than overload it?

@jonathanKingston
Copy link
Contributor Author

As this has had no feedback since Feb, it's going to be bitrotted and I don't intend to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Chromium browser_tests working
1 participant