Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n XTB and messages.json for 79.0.3945.70 #4183

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Dec 9, 2019

Fixes brave/brave-browser#7271

Submitter Checklist:

Test Plan:

Some of the changes to test:

For 1.1.x (since 1.0):

1. Issue #2301: Enable push messaging

  • Use Google Services for Push Messaging

2. Initial implementation of P3A (Privacy-Preserving Product Analytics) (#3242)

  • Brave uses completely private product analytics to estimate the overall usage of certain features
  • Got it
  • Disable
  • Automatically send completely private product analytics to Brave
  • This anonymous info only lets Brave estimate the overall usage of certain features.

3. Fixes brave/brave-browser#6147 - Makes tipping banner accessible

  • You can also set a monthly recurring contribution from within the Brave Rewards panel.
  • Send Tip (instead of "Send my Tip")

4. Fixes brave/brave-browser#5996 - Adds new Monthly Banner

  • Monthly Contribution (instead of "Tip this site monthly")
  • Set... (Button text for setting monthly contribution)

For master (since Chromium 78):

1. Add webcompat issue reporting dialog (#3420)

  • You’re browsing this site without Brave’s privacy and security protections...
  • Report a broken site

2. BAT Points round 2.1 (#3971)

  • You can now earn points for watching privacy-respecting ads.

3. Updates copy for monthly flows (#4086)

  • Your monthly contributions have been processed! (instead of "Your monthly tips have been processed!")

Note: some Croatian translations weren't delivered on time.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.4.x - Nightly milestone Dec 9, 2019
@mkarolin mkarolin requested a review from bsclifton December 9, 2019 19:00
@mkarolin mkarolin requested a review from NejcZdovc as a code owner December 9, 2019 19:00
@mkarolin mkarolin self-assigned this Dec 9, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄👍

@mkarolin mkarolin merged commit 72d2df7 into master Dec 9, 2019
@mkarolin mkarolin deleted the maxk-l10n-for-c79 branch December 9, 2019 23:09
mkarolin added a commit that referenced this pull request Dec 9, 2019
Update l10n XTB and messages.json for 79.0.3945.70
mkarolin added a commit that referenced this pull request Dec 9, 2019
Update l10n XTB and messages.json for 79.0.3945.70
mkarolin added a commit that referenced this pull request Dec 9, 2019
Update l10n XTB and messages.json for 79.0.3945.70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants