Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAT Points round 2.1 #3971

Merged
merged 1 commit into from
Nov 13, 2019
Merged

BAT Points round 2.1 #3971

merged 1 commit into from
Nov 13, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 11, 2019

Fixes: brave/brave-browser#6877

Submitter Checklist:

Test Plan:

Defined in: brave/brave-browser#6654

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 0.74.x - Nightly milestone Nov 11, 2019
@ryanml ryanml requested a review from a team November 11, 2019 21:23
@ryanml ryanml requested a review from NejcZdovc as a code owner November 11, 2019 21:23
@ryanml ryanml self-assigned this Nov 11, 2019
@ryanml ryanml force-pushed the bp2 branch 2 times, most recently from 2f6b9b8 to 69e5d3e Compare November 11, 2019 21:31
Copy link
Contributor

@masparrow masparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml
Copy link
Contributor Author

ryanml commented Nov 12, 2019

All CI pipeline steps pass with this one, unrelated post build failure

@ryanml ryanml merged commit 81e1839 into master Nov 13, 2019
@ryanml ryanml deleted the bp2 branch November 13, 2019 06:38
This was referenced Nov 13, 2019
ryanml added a commit that referenced this pull request Nov 14, 2019
ryanml added a commit that referenced this pull request Nov 14, 2019
ryanml added a commit that referenced this pull request Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BAT Points work needs to be in all other channels
3 participants