-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API to open Shields and Rewards dialog UI (uplift to 0.71.x) #3872
API to open Shields and Rewards dialog UI (uplift to 0.71.x) #3872
Conversation
Fix master debug build failure from BraveActionAPIDependencyManager
Restarting on
|
Looks like it failed again due to the following dependency vulnerability as per https://ci.brave.com/job/brave-browser-build-pr/job/pr3664_trigger-internal-extension-popup_0.71.x/2/execution/node/343/log/:
Above issue is addressed via #3878. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into 0.72.x
approved after deliberating with @brave/uplift-approvers. CI/Travis
passed but CI/Jenkins
failed due to the handlebars
dependency being vulnerable. However, this has been addressed via #3878.
Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.
Uplift of #3664
Fixes brave/brave-browser#6419
Fixes brave/brave-browser#6628
Approved, please ensure that before merging:
After you merge: