Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nightly instead of canary on Windows #194

Merged
merged 2 commits into from
Jun 27, 2018
Merged

Use nightly instead of canary on Windows #194

merged 2 commits into from
Jun 27, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 27, 2018 •
edited
Loading

Test - ProductInstallDetailsTest and MakeProductDetailsTest

Issue: brave/brave-browser#394

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

yarn test brave_unit_tests --filter=*Product*

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@simonhong
Use nightly instead of canary
031491f 
Test - ProductInstallDetailsTest and MakeProductDetailsTest
@simonhong simonhong self-assigned this Jun 27, 2018
@simonhong simonhong requested a review from darkdh June 27, 2018 10:02
darkdh
darkdh requested changes Jun 27, 2018
View reviewed changes
chromium_src/chrome/install_static/chromium_install_modes.cc Outdated
@@ -124,21 +124,21 @@ const InstallConstants kInstallModes[] = {
sizeof(kInstallModes[0]),
CANARY_INDEX, // The mode for the side-by-side canary channel.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also change this to NIGHTLY_INDEX along with the header and tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

chromium_src/chrome/install_static/brave_product_install_details_unittest.cc Outdated
DEVELOPER_INDEX, false, L"",
},
};
#endif // !GOOGLE_CHROME_BUILD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be !OFFICIAL_BUILD

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@darkdh darkdh merged commit be71eb3 into master Jun 27, 2018
@simonhong
Copy link
Member Author

@darkdh Thanks for review! 😄

@simonhong simonhong deleted the use_nightly_on_windows branch August 19, 2018 23:23
NejcZdovc added a commit that referenced this pull request Dec 10, 2018
@NejcZdovc
Merge pull request #194 from ryanml/fix-2340
ab50d0e 
Adds publisherKey to OnExcludedSitesChanged callback
NejcZdovc added a commit that referenced this pull request Dec 11, 2018
@NejcZdovc
Merge pull request #194 from ryanml/fix-2340
d5602b1 
Adds publisherKey to OnExcludedSitesChanged callback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdh darkdh darkdh approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @darkdh