[Brave News]: Update Discover section to match new design spec. #15755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Begin work on scroll buttons Wire up scroll buttons Only show scroll buttons on hover Clean up discover page Popular sources should use carousel Button opacity transitions Work when the container shrinks Begin work on pages Linking Improve perf Get link to align nicely Popular page Page headers localize Keep settings open on back pressed
fallaciousreasoning
force-pushed
the
bn-carousels
branch
from
95e43fc to
1756ce5
Compare
petemill
requested changes
Nov 3, 2022
|
Good call @petemill! I've updated it. |
petemill
reviewed
Nov 4, 2022
| line-height: 18px; | ||
| color: var(--interactive5); | ||
| cursor: pointer; | ||
|
|
petemill
approved these changes
Nov 4, 2022
Comment on lines
+34
to
+38
| flex: 5; | ||
| text-align: center; | ||
| ` | ||
|
|
||
| const Spacer = styled.div`flex: 1;` |
There was a problem hiding this comment.
This is an interesting way to center the text. It breaks down if the word "Back" is extremely long, but that's very unlikely!
Verified
|
| Brave | 1.47.48 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64) |
|---|---|
| Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097} |
| OS | macOS Version 13.1 (Build 22C5033e) |
Steps:
- installed
1.47.48 - launched Brave
- clicked on
Skip welcome tour - opened
brave://flags - set
brave://flags/#brave-news-v2toEnabled - clicked
Relaunch - opened a new-tab page
- clicked on
Customize - clicked on
Brave News - clicked on
Turn on Brave News - checked the
Customize Brave Newsdialog
Confirmed the following changes:
Popularsources appeared firstSuggestionsappeared second (after following a few sources, then returning to this dialog)Channelsappeared third- All channels were visible (no
Show morebutton) Popular&Suggestionsappeared in a carousel, with aView Alllink taking me to a full page view- removed previous
Sourcessection
order of appearance |
all channels visible |
carousel |
|---|---|---|
 |
 |
 |
petemill
added a commit
that referenced
this pull request
Nov 7, 2022
[Brave News]: Update Discover section to match new design spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#26462
Screencast.from.2022-11-02.17-19-05.webm
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: