Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed on mouseover doesn't work with right side sidebar #15612

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 24, 2022

fix brave/brave-browser#26198

Mouse over detect widget's bound was not updated for right-side sidebar.
Also event detect widget's bounds claculation is updated.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

SidebarBrowserTest.EventDetectWidgetTest

@simonhong simonhong requested a review from sangwoo108 October 24, 2022 02:07
@simonhong simonhong self-assigned this Oct 24, 2022
@simonhong simonhong marked this pull request as draft October 24, 2022 04:56
@simonhong simonhong marked this pull request as ready for review October 24, 2022 07:08
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong force-pushed the sidebar_on_mouseover_right_sidebar branch from fc613ab to 47471b3 Compare October 24, 2022 08:49
@simonhong simonhong enabled auto-merge October 24, 2022 09:15
@simonhong simonhong merged commit cfef9b5 into master Oct 24, 2022
@simonhong simonhong deleted the sidebar_on_mouseover_right_sidebar branch October 24, 2022 11:11
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Oct 24, 2022
brave-builds pushed a commit that referenced this pull request Oct 24, 2022
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.47.18 Chromium: 107.0.5304.62 (Official Build) nightly (64-bit)
-- | --
Revision | 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS | Windows 11 Version 22H2 (Build 22621.675)

Reproduced the original issue using the STR/Cases outlined via brave/brave-browser#26198 (comment) with 1.47.13 Chromium: 107.0.5304.62 as per the following:

reproducedIssue.mp4

Verified the same STR/Cases as per the above with 1.47.18 Chromium: 107.0.5304.62 as per the following:

Settings.Appearance.-.Brave.2022-10-26.00-19-52.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar's On mouseover option doesn't work with right side sidebar
3 participants