-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy load images in the Brave News V2 UI #15586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
Deploy storybook and provide a unique URL for each build
label
Oct 21, 2022
fallaciousreasoning
force-pushed
the
bn-lazy-images
branch
from
October 21, 2022 01:38
296a596
to
0fc1579
Compare
A Storybook has been deployed to preview UI for the latest push |
sangwoo108
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
components/brave_new_tab_ui/components/default/braveToday/useUnpaddedImageUrl.ts
Show resolved
Hide resolved
components/brave_new_tab_ui/components/default/braveToday/useUnpaddedImageUrl.ts
Outdated
Show resolved
Hide resolved
components/brave_new_tab_ui/components/default/braveToday/useUnpaddedImageUrl.ts
Show resolved
Hide resolved
A Storybook has been deployed to preview UI for the latest push |
sangwoo108
approved these changes
Oct 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM 👍
Verified
|
Brave | 1.47.47 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64) |
---|---|
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097} |
OS | macOS Version 13.1 (Build 22C5033e) |
Steps:
- installed
1.47.47
- launched Brave
- clicked on
Skip welcome tour
- opened
brave://flags
- set
brave://flags/#brave-news-v2
toEnabled
- clicked on
Relaunch
- opened a new-tab page
- clicked on
Customize
- clicked on
Brave News
- clicked on
Turn on Brave News
Confirmed the Channels
icons lazily-loaded, filling in as they scrolled into view
petemill
pushed a commit
that referenced
this pull request
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#26161
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on