Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News] Suggestions Followup for #15447 #15522

Merged
merged 5 commits into from
Oct 27, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Oct 18, 2022

Resolves brave/brave-browser#25563

This is some suggestions work/cleanup which @petemill and I decided would be better off in a followup PR, in order to land the suggestions before branch.

It includes:

  • Lazy loading the suggestions in the BraveNewsContext
  • Unittests
  • More robust parsing of the similarity file

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 18, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@LorenzoMinto
Copy link
Member

LorenzoMinto commented Oct 19, 2022

@fallaciousreasoning @petemill we could also add some minimal noising or some sampling to the ranked suggestion list so that on different openings of the settings the suggestions are in a different order. Wdyt?
cc @mattmcalister

@fallaciousreasoning fallaciousreasoning changed the title Brave News Suggestions Followup for #15447 [Brave News] Suggestions Followup for #15447 Oct 27, 2022
@fallaciousreasoning fallaciousreasoning enabled auto-merge (squash) October 27, 2022 02:03
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning merged commit de51e0c into master Oct 27, 2022
@fallaciousreasoning fallaciousreasoning deleted the bn-suggestions-followup branch October 27, 2022 03:33
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add source suggestions for Brave News
4 participants