Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show download prompt by default #154

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Show download prompt by default #154

merged 1 commit into from
Jun 11, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 11, 2018

close brave/brave-browser#308

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

BraveProfilePrefsBrowserTest.DownloadPromptDefault

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@simonhong simonhong self-assigned this Jun 11, 2018
@simonhong simonhong requested a review from bbondy June 11, 2018 08:30
@bbondy bbondy merged commit 9dcffc8 into master Jun 11, 2018
@simonhong simonhong deleted the download_prompt branch June 14, 2018 09:48
NejcZdovc pushed a commit that referenced this pull request Dec 10, 2018
Fixes wallet create status; Fixes favicon for the panel
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 5, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
petemill pushed a commit that referenced this pull request Jul 27, 2020
petemill pushed a commit that referenced this pull request Jul 27, 2020
petemill pushed a commit that referenced this pull request Jul 28, 2020
petemill pushed a commit that referenced this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask where to save each file before downloading should be enabled by default
2 participants