Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 104.0.5112.57 to Chromium 104.0.5112.69 (uplift to 1.42.x). #14368

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Upgrade from Chromium 104.0.5112.57 to Chromium 104.0.5112.69 (uplift to 1.42.x). #14368

merged 1 commit into from
Jul 28, 2022

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jul 27, 2022 •
edited by kjozwiak
Loading

Fixes brave/brave-browser#24291
Uplift from #14362

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin
Merge pull request #14362 from brave/104.0.5112.69_master
436b712 
Upgrade from Chromium 104.0.5112.57 to Chromium 104.0.5112.69
@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Jul 27, 2022
@mkarolin mkarolin requested a review from a team as a code owner July 27, 2022 20:28
@mkarolin mkarolin self-assigned this Jul 27, 2022
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jul 27, 2022
@kjozwiak kjozwiak added this to the 1.42.x - Release milestone Jul 28, 2022
kjozwiak
kjozwiak approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.42.x approved 👍

@kjozwiak kjozwiak merged commit 0e3a53a into 1.42.x Jul 28, 2022
@kjozwiak kjozwiak deleted the 104.0.5112.69_1.42.x branch July 28, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@mkarolin mkarolin

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit
Projects
None yet
Milestone
1.42.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@mkarolin @kjozwiak