Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added import from Vivaldi #13990

Merged
merged 6 commits into from
Jul 14, 2022
Merged

Added import from Vivaldi #13990

merged 6 commits into from
Jul 14, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jun 28, 2022 •
edited
Loading

Resolves brave/brave-browser#23704

  • Added import from Vivaldi
  • Reworked import patches via chromium_src overriding
vivaldi.mp4

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Check import from Vivaldi for desktop platforms

@spylogsster spylogsster changed the title Added Vivaldi wip: Added import from Vivaldi Jun 28, 2022
@spylogsster spylogsster force-pushed the brave-23704 branch 2 times, most recently from d6b221e to 5f7b4af Compare June 28, 2022 16:46
@spylogsster spylogsster requested a review from bsclifton June 28, 2022 17:05
@spylogsster spylogsster force-pushed the brave-13334 branch 2 times, most recently from dad1c50 to 1d62362 Compare June 29, 2022 11:56
@spylogsster spylogsster force-pushed the brave-23704 branch 2 times, most recently from 73a7852 to 06e2151 Compare June 29, 2022 14:10
@spylogsster spylogsster force-pushed the brave-13334 branch 17 times, most recently from c7ddfe4 to c24d6d8 Compare July 3, 2022 07:17
Base automatically changed from brave-13334 to master July 4, 2022 10:30
@spylogsster
Copy link
Contributor Author

spylogsster commented Jul 12, 2022 •
edited
Loading

Importer works great! Left a few comments 😄

Not specific to this PR - but it would also be great to have a test for GetChromeSourceProfiles in brave/common/importer/chrome_importer_utils.cc, to ensure a profile parsed out (given a local state JSON w/ profile element)

added test in b22bbfecae87bb70ffdb45bc9df45526eb75d905

@spylogsster spylogsster force-pushed the brave-23704 branch 5 times, most recently from b22bbfe to f1415a4 Compare July 12, 2022 13:41
iefremov
iefremov approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unlocking components/p3a

@spylogsster spylogsster force-pushed the brave-23704 branch 2 times, most recently from cc72d90 to c3ef3ba Compare July 12, 2022 17:58
bsclifton
bsclifton approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Code is good too. Thanks for including the test 😄

@bsclifton
Copy link
Member

Created https://github.com/brave/stats/issues/929 to track the P3A changes needed

@spylogsster spylogsster force-pushed the brave-23704 branch 7 times, most recently from c12fe3f to a3c006f Compare July 14, 2022 08:23
@spylogsster spylogsster merged commit 5aa6867 into master Jul 14, 2022
@spylogsster spylogsster deleted the brave-23704 branch July 14, 2022 14:18
@github-actions github-actions bot added this to the 1.43.x - Nightly milestone Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@pes10k pes10k pes10k left review comments

@iefremov iefremov iefremov approved these changes

@bridiver bridiver bridiver approved these changes

Assignees

@spylogsster spylogsster

Labels
None yet
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging this pull request may close these issues.

Import from Vivaldi
5 participants
@spylogsster @bsclifton @bridiver @pes10k @iefremov