Fixes summary being displayed before enabled #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaiplesa
approved these changes
Jan 18, 2019
NejcZdovc
added a commit
that referenced
this pull request
Jan 18, 2019
Fixes summary being displayed before enabled
NejcZdovc
added a commit
that referenced
this pull request
Jan 18, 2019
Fixes summary being displayed before enabled
bridiver
reviewed
Jan 31, 2019
| @@ -25,7 +25,7 @@ void ExtensionRewardsServiceObserver::OnWalletInitialized( | |||
| int error_code) { | |||
| extensions::EventRouter* event_router = | |||
| extensions::EventRouter::Get(profile_); | |||
| if (event_router) { | |||
| if (event_router && error_code == 0) { | |||
There was a problem hiding this comment.
this doesn't seem right, we should still be broadcasting the event along with the error code so the listeners can handle it if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#2962
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: