-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on the Rewards extension #13719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/storybook-url
Deploy storybook and provide a unique URL for each build
potential-layer-violation-fixes
This PR touches a BUILD.gn file with check_includes=false
labels
Jun 9, 2022
zenparsing
force-pushed
the
ksmith-rewards-panel-webui
branch
from
June 9, 2022 19:55
ed91fbf
to
3461375
Compare
A Storybook has been deployed to preview UI for the latest push |
zenparsing
force-pushed
the
ksmith-rewards-panel-webui
branch
from
June 9, 2022 23:51
3461375
to
5268471
Compare
A Storybook has been deployed to preview UI for the latest push |
zenparsing
force-pushed
the
ksmith-rewards-panel-webui
branch
from
June 10, 2022 14:20
5268471
to
1c2592b
Compare
zenparsing
removed
the
CI/storybook-url
Deploy storybook and provide a unique URL for each build
label
Jun 10, 2022
zenparsing
force-pushed
the
ksmith-rewards-panel-webui
branch
2 times, most recently
from
June 13, 2022 14:56
ca047fb
to
d45a8ff
Compare
zenparsing
force-pushed
the
ksmith-rewards-panel-webui
branch
2 times, most recently
from
June 14, 2022 17:46
af35cc1
to
1c54006
Compare
zenparsing
changed the title
[WIP] Remove dependency on the Rewards extension
Remove dependency on the Rewards extension
Jun 14, 2022
zenparsing
force-pushed
the
ksmith-rewards-panel-webui
branch
from
June 14, 2022 19:21
1c54006
to
b543123
Compare
bridiver
reviewed
Jun 14, 2022
bridiver
reviewed
Jun 14, 2022
bridiver
reviewed
Jun 14, 2022
bridiver
reviewed
Jun 14, 2022
bridiver
reviewed
Jun 14, 2022
bridiver
reviewed
Jun 14, 2022
zenparsing
force-pushed
the
ksmith-rewards-panel-webui
branch
3 times, most recently
from
June 18, 2022 13:57
e711a51
to
19bfbe4
Compare
bridiver
reviewed
Jun 29, 2022
bridiver
reviewed
Jun 29, 2022
bridiver
reviewed
Jun 29, 2022
bridiver
reviewed
Jun 29, 2022
bridiver
reviewed
Jun 29, 2022
bridiver
reviewed
Jun 29, 2022
bridiver
reviewed
Jun 29, 2022
bridiver
reviewed
Jun 29, 2022
bridiver
reviewed
Jun 30, 2022
zenparsing
force-pushed
the
ksmith-rewards-panel-webui
branch
2 times, most recently
from
June 30, 2022 15:40
f84fabf
to
649af3a
Compare
bridiver
reviewed
Jun 30, 2022
bridiver
reviewed
Jun 30, 2022
bridiver
reviewed
Jun 30, 2022
components/brave_rewards/browser/test/common/rewards_browsertest_context_helper.cc
Show resolved
Hide resolved
bridiver
reviewed
Jun 30, 2022
zenparsing
force-pushed
the
ksmith-rewards-panel-webui
branch
8 times, most recently
from
July 5, 2022 14:46
aab1709
to
b07c19b
Compare
bridiver
approved these changes
Jul 6, 2022
zenparsing
force-pushed
the
ksmith-rewards-panel-webui
branch
from
July 7, 2022 14:14
b07c19b
to
964b84c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#22423
High-level overview:
The goal of this change is to ensure that all Rewards features can be run without loading the Rewards built-in extension. Currently, the Rewards extension is used to:
In this PR:
RewardsTabHelper
is modified to take responsibility for recording tab/creator activity.RewardsPanelCoordinator
is added to route "panel requests" to the appropriate handler. Code that previously loaded the Rewards extension and calledBraveActionAPI::ShowActionUI
have been refactored to use this coordinator.BraveRewardsActionView
is added to display the Rewards icon button.MojoBubbleWebUIController
is added to display the Rewards panel (rewards_panel_ui.h
).BraveRewardsActionView
. When enabled, the Rewards extension should not need to be loaded.Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Regression Testing
The following cases should be tested for regressions with the feature flag off:
With the feature flag on, the following cases should be tested in addition to the cases above: