Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove the Rewards extension #13191

Closed
wants to merge 1 commit into from
Closed

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Apr 27, 2022

Resolves brave/brave-browser#22423

Basic idea for POC:

  • Introduce a new service RewardsPanelService that provides a communication channel between components that want to open the Rewards panel and the Rewards panel UI classes.
  • Extend the responsibilities of the existing RewardsTabHelper to store the current publisher ID for a given tab.
  • Introduce a MojoBubbleWebUIController subclass for displaying the panel, along with mojom types for browser/webUI communication.
  • Add a BraveRewardsActionView button, subclassed from ToolbarButton (in order to support a context menu), that manages Rewards icon badges and opening/closing the panel.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Apr 27, 2022
@zenparsing zenparsing force-pushed the ksmith-rewards-tabhelper branch 7 times, most recently from b9e3d0d to 387a09e Compare May 3, 2022 21:24
@zenparsing zenparsing force-pushed the ksmith-rewards-tabhelper branch 7 times, most recently from 0258ab8 to f326afd Compare May 16, 2022 15:39
@zenparsing zenparsing force-pushed the ksmith-rewards-tabhelper branch 2 times, most recently from ffd5105 to 59abad3 Compare May 20, 2022 20:20
@zenparsing zenparsing force-pushed the ksmith-rewards-tabhelper branch 4 times, most recently from 4744d77 to ea84e7e Compare May 26, 2022 20:51
@zenparsing zenparsing changed the title WIP: Remove dependency on rewards extension Remove the Rewards extension May 26, 2022
@zenparsing zenparsing changed the title Remove the Rewards extension [WIP] Remove the Rewards extension May 27, 2022
@zenparsing zenparsing force-pushed the ksmith-rewards-tabhelper branch 5 times, most recently from c0faf11 to 9806397 Compare June 2, 2022 20:43
@zenparsing zenparsing force-pushed the ksmith-rewards-tabhelper branch from 9806397 to a25b7e1 Compare June 3, 2022 13:25
@zenparsing zenparsing closed this Jun 9, 2022
@zenparsing zenparsing deleted the ksmith-rewards-tabhelper branch June 29, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate away from Rewards Extension to WebUI: Make background page of Reward Extension non-persistent
1 participant