Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Network Selector zIndex #12470

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Mar 3, 2022

Description

Increased the z-index on the Network Selector on the Portfolio page so it doesn't get cut off by the Line Charts loading blur.

Resolves brave/brave-browser#21423

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Before:

Screen.Recording.2022-03-02.at.6.47.41.PM.mov

After:

Screen.Recording.2022-03-02.at.6.38.12.PM.mov

@Douglashdaniel Douglashdaniel self-assigned this Mar 3, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 3, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel added this to the 1.38.x - Nightly milestone Mar 3, 2022
@Douglashdaniel Douglashdaniel merged commit df157e6 into master Mar 3, 2022
@Douglashdaniel Douglashdaniel deleted the fixed-network-selector-z-index branch March 3, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet graph blur layer covers network selector
3 participants