Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invisible nodes (Nodes under Pending Bookmarks and itself) in bookmarks reducer #1179

Merged
merged 1 commit into from
Dec 22, 2018

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Dec 21, 2018

fix brave/brave-browser#2579

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Setup sync chain between device A and device B
  2. Wait until device list is synced on all device
  3. Add a bookmark/folder on device A
  4. Wait for it to appear on device B (for first time bookmark fetch to ensure it will use SQS in the future)
  5. Import 1000 or more bookmarks on device A
  6. Open bravee://bookmarks/ along with the console
  7. Wait until all bookmarks are synced on device B
  8. There shouldn't be any errors in the console of bravee://bookmarks/

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@darkdh darkdh self-assigned this Dec 21, 2018
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@darkdh darkdh merged commit 78fd6b8 into master Dec 22, 2018
darkdh added a commit that referenced this pull request Dec 22, 2018
Handle invisible nodes (Nodes under Pending Bookmarks and itself) in bookmarks reducer
@darkdh
Copy link
Member Author

darkdh commented Dec 22, 2018

master: 78fd6b8
0.60.x: 630bb53
0.59.x 27ebc03

@cezaraugusto
Copy link
Contributor

pr requesting uplift approval to 59 at #1225

@cezaraugusto
Copy link
Contributor

0.59.x 27ebc03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

intermittent error in terminal while syncing two devices 'Cannot read property 'children' of undefined
4 participants