Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): display exact date/time as tooltip in transaction history #11593

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

onyb
Copy link
Member

@onyb onyb commented Dec 14, 2021

Resolves brave/brave-browser#19789.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Demo

Screenshot 2021-12-14 at 5 00 09 PM

@onyb onyb requested review from Douglashdaniel and a team December 14, 2021 11:40
@onyb onyb self-assigned this Dec 14, 2021
@onyb onyb requested a review from muliswilliam December 14, 2021 14:38
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we confirm that the tooltip doesn't get cut off when the Browser windows width is reduced all the way?

@onyb onyb force-pushed the f/wallet/timestamp branch from d02fd12 to 99adc11 Compare December 14, 2021 20:48
@onyb
Copy link
Member Author

onyb commented Dec 14, 2021

Fixed the tooltip issue.
Screenshot 2021-12-15 at 2 21 13 AM

Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@onyb onyb merged commit 74d7aea into master Dec 15, 2021
@onyb onyb deleted the f/wallet/timestamp branch December 15, 2021 09:20
@onyb onyb added this to the 1.35.x - Nightly milestone Dec 15, 2021
onyb added a commit that referenced this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet transactions: show exact time as tooltip when hovering on the relative time ago
2 participants