From d2904bab689a1808f35a1a766b648a38994f2a16 Mon Sep 17 00:00:00 2001 From: Nuo Xu Date: Thu, 27 Apr 2023 14:11:54 -0700 Subject: [PATCH] Fix brave/brave-ios#7326: Add unit tests for update in asset detail store (brave/brave-ios#7351) --- .../Crypto/Stores/AssetDetailStore.swift | 2 +- .../Preview Content/MockContent.swift | 31 ++ .../AssetDetailStoreTests.swift | 510 ++++++++++++++++++ 3 files changed, 542 insertions(+), 1 deletion(-) create mode 100644 Tests/BraveWalletTests/AssetDetailStoreTests.swift diff --git a/Sources/BraveWallet/Crypto/Stores/AssetDetailStore.swift b/Sources/BraveWallet/Crypto/Stores/AssetDetailStore.swift index 740656fff4ae..58499a61e3b5 100644 --- a/Sources/BraveWallet/Crypto/Stores/AssetDetailStore.swift +++ b/Sources/BraveWallet/Crypto/Stores/AssetDetailStore.swift @@ -221,7 +221,7 @@ class AssetDetailStore: ObservableObject { buyOptions = [.ramp, .transak] } self.allBuyTokensAllOptions = await blockchainRegistry.allBuyTokens(in: network, for: buyOptions) - let buyTokens = allBuyTokensAllOptions.flatMap{ $0.value } + let buyTokens = allBuyTokensAllOptions.flatMap { $0.value } return buyTokens.first(where: { $0.symbol.caseInsensitiveCompare(symbol) == .orderedSame }) != nil } diff --git a/Sources/BraveWallet/Preview Content/MockContent.swift b/Sources/BraveWallet/Preview Content/MockContent.swift index 15645520c735..8f8b69003a81 100644 --- a/Sources/BraveWallet/Preview Content/MockContent.swift +++ b/Sources/BraveWallet/Preview Content/MockContent.swift @@ -339,4 +339,35 @@ extension TransactionSummary { ) } } + +extension BraveWallet.CoinMarket { + static var mockCoinMarketBitcoin: BraveWallet.CoinMarket { + .init( + id: "bitcoin", + symbol: "btc", + name: "Bitcoin", + image: "https://assets.cgproxy.brave.com/coins/images/1/large/bitcoin.png?1547033579", + marketCap: 547558353670, + marketCapRank: 1, + currentPrice: 28324, + priceChange24h: 163.96, + priceChangePercentage24h: 0.58225, + totalVolume: 30825602847 + ) + } + static var mockCoinMarketEth: BraveWallet.CoinMarket { + .init( + id: "ethereum", + symbol: "eth", + name: "Ethereum", + image: "https://assets.cgproxy.brave.com/coins/images/279/large/ethereum.png?1595348880", + marketCap: 223719056533, + marketCapRank: 2, + currentPrice: 1860.57, + priceChange24h: -4.2550480604149925, + priceChangePercentage24h: -0.22817, + totalVolume: 15998007227 + ) + } +} #endif diff --git a/Tests/BraveWalletTests/AssetDetailStoreTests.swift b/Tests/BraveWalletTests/AssetDetailStoreTests.swift new file mode 100644 index 000000000000..a0a5ee090dd3 --- /dev/null +++ b/Tests/BraveWalletTests/AssetDetailStoreTests.swift @@ -0,0 +1,510 @@ +// Copyright 2023 The Brave Authors. All rights reserved. +// This Source Code Form is subject to the terms of the Mozilla Public +// License, v. 2.0. If a copy of the MPL was not distributed with this +// file, You can obtain one at https://mozilla.org/MPL/2.0/. + +import Combine +import XCTest +import BraveCore +@testable import BraveWallet + +class AssetDetailStoreTests: XCTestCase { + private var cancellables: Set = .init() + + func testUpdateWithBlockchainToken() { + let currencyFormatter = NumberFormatter().then { $0.numberStyle = .currency } + let formatter = WeiFormatter(decimalFormatStyle: .decimals(precision: 18)) + + let assetRatioService = BraveWallet.TestAssetRatioService() + assetRatioService._price = { _, _, _, completion in + completion(true, [.init(fromAsset: BraveWallet.BlockchainToken.previewToken.tokenId, toAsset: "btc", price: "0.1", assetTimeframeChange: "1"), .init(fromAsset: BraveWallet.BlockchainToken.previewToken.tokenId, toAsset: "usd", price: "1", assetTimeframeChange: "1")]) + } + assetRatioService._priceHistory = { _, _, _, completion in + completion(true, [.init(date: Date(), price: "0.99")]) + } + + let keyringService = BraveWallet.TestKeyringService() + keyringService._keyringInfo = { + $1(.mockDefaultKeyringInfo) + } + keyringService._addObserver = { _ in } + + let mockEthBalance: Double = 1 + let ethBalanceWei = formatter.weiString( + from: mockEthBalance, + radix: .hex, + decimals: Int(BraveWallet.BlockchainToken.previewToken.decimals) + ) ?? "" + let formattedEthBalance = currencyFormatter.string(from: NSNumber(value: mockEthBalance)) ?? "" + let rpcService = BraveWallet.TestJsonRpcService() + rpcService._allNetworks = { + $1([.mockMainnet]) + } + rpcService._network = { + $1(.mockMainnet) + } + rpcService._balance = { _, _, _, completion in + completion(ethBalanceWei, .success, "") + } + + let walletService = BraveWallet.TestBraveWalletService() + walletService._defaultBaseCurrency = { + $0("usd") + } + walletService._userAssets = { + $2([.previewToken]) + } + walletService._addObserver = { _ in } + + let txService = BraveWallet.TestTxService() + txService._allTransactionInfo = { + $2([.previewConfirmedSend]) + } + txService._addObserver = { _ in } + + let blockchainRegistry = BraveWallet.TestBlockchainRegistry() + blockchainRegistry._buyTokens = { + $2([.previewToken]) + } + blockchainRegistry._allTokens = { + $2([.previewToken]) + } + + let solTxManagerProxy = BraveWallet.TestSolanaTxManagerProxy() + solTxManagerProxy._estimatedTxFee = { + $1(UInt64(0.1), .success, "") + } + + let swapService = BraveWallet.TestSwapService() + swapService._isSwapSupported = { + $1(true) + } + + // setup store + let store = AssetDetailStore( + assetRatioService: assetRatioService, + keyringService: keyringService, + rpcService: rpcService, + walletService: walletService, + txService: txService, + blockchainRegistry: blockchainRegistry, + solTxManagerProxy: solTxManagerProxy, + swapService: swapService, + assetDetailType: .blockchainToken(.previewToken) + ) + + let assetDetailException = expectation(description: "update-blockchainToken") + assetDetailException.expectedFulfillmentCount = 14 + store.$network + .dropFirst() + .sink { network in + defer { assetDetailException.fulfill() } + XCTAssertEqual(network, .mockMainnet) + } + .store(in: &cancellables) + store.$isBuySupported + .dropFirst() + .sink { + defer { assetDetailException.fulfill() } + XCTAssertTrue($0) + } + .store(in: &cancellables) + store.$isSendSupported + .dropFirst() + .sink { + defer { assetDetailException.fulfill() } + XCTAssertTrue($0) + } + .store(in: &cancellables) + store.$isSwapSupported + .dropFirst() + .sink { + defer { assetDetailException.fulfill() } + XCTAssertTrue($0) + } + .store(in: &cancellables) + store.$btcRatio + .dropFirst() + .sink { + defer { assetDetailException.fulfill() } + XCTAssertEqual($0, "0.1 BTC") + } + .store(in: &cancellables) + store.$priceHistory + .dropFirst() + .sink { priceHistory in + defer { assetDetailException.fulfill() } + XCTAssertEqual(priceHistory.count, 1) + XCTAssertEqual(priceHistory[0].price, "0.99") + } + .store(in: &cancellables) + store.$price + .dropFirst() + .sink { + defer { assetDetailException.fulfill() } + XCTAssertEqual($0, "$1.00") + } + .store(in: &cancellables) + store.$priceIsDown + .dropFirst() + .sink { + defer { assetDetailException.fulfill() } + XCTAssertFalse($0) + } + .store(in: &cancellables) + store.$priceDelta + .dropFirst() + .sink { + defer { assetDetailException.fulfill() } + XCTAssertEqual($0, "1%") + } + .store(in: &cancellables) + store.$accounts + .dropFirst() + .sink { accounts in + defer { assetDetailException.fulfill() } + XCTAssertEqual(accounts.count, 1) + XCTAssertEqual(accounts[0].account, .mockEthAccount) + XCTAssertEqual(accounts[0].balance, String(format: "%.4f", mockEthBalance)) + XCTAssertEqual(accounts[0].fiatBalance, formattedEthBalance) + } + .store(in: &cancellables) + store.$transactionSummaries + .dropFirst() + .sink { tx in + defer { assetDetailException.fulfill() } + XCTAssertEqual(tx.count, 1) + XCTAssertEqual(tx[0].txInfo.id, BraveWallet.TransactionInfo.previewConfirmedSend.id) + } + .store(in: &cancellables) + store.$isLoadingPrice + .dropFirst() + .collect(2) + .sink { values in + defer { assetDetailException.fulfill() } + guard let value = values.last + else { + XCTFail("Unexpected isLoadingPrice") + return + } + XCTAssertFalse(value) + } + .store(in: &cancellables) + store.$isInitialState + .dropFirst() + .sink { + defer { assetDetailException.fulfill() } + XCTAssertFalse($0) + } + .store(in: &cancellables) + store.$isLoadingChart + .dropFirst() + .collect(2) + .sink { values in + defer { assetDetailException.fulfill() } + guard let value = values.last + else { + XCTFail("Unexpected isLoadingChart") + return + } + XCTAssertFalse(value) + } + .store(in: &cancellables) + + store.update() + wait(for: [assetDetailException], timeout: 1) + } + + func testUpdateWithCoinMarket() { + let currencyFormatter = NumberFormatter().then { $0.numberStyle = .currency } + let formatter = WeiFormatter(decimalFormatStyle: .decimals(precision: 18)) + + let assetRatioService = BraveWallet.TestAssetRatioService() + assetRatioService._price = { _, _, _, completion in + completion(true, [.init(fromAsset: BraveWallet.BlockchainToken.previewToken.tokenId, toAsset: "btc", price: "0.1", assetTimeframeChange: "1")]) + } + assetRatioService._priceHistory = { _, _, _, completion in + completion(true, [.init(date: Date(), price: "0.99")]) + } + + let keyringService = BraveWallet.TestKeyringService() + keyringService._keyringInfo = { + $1(.mockDefaultKeyringInfo) + } + keyringService._addObserver = { _ in } + + let mockEthBalance: Double = 1 + let ethBalanceWei = formatter.weiString( + from: mockEthBalance, + radix: .hex, + decimals: Int(BraveWallet.BlockchainToken.previewToken.decimals) + ) ?? "" + let formattedEthBalance = currencyFormatter.string(from: NSNumber(value: mockEthBalance)) ?? "" + let rpcService = BraveWallet.TestJsonRpcService() + rpcService._network = { + $1(.mockMainnet) + } + rpcService._balance = { _, _, _, completion in + completion(ethBalanceWei, .success, "") + } + + let walletService = BraveWallet.TestBraveWalletService() + walletService._defaultBaseCurrency = { + $0("usd") + } + walletService._addObserver = { _ in } + walletService._selectedCoin = { + $0(.eth) + } + + let txService = BraveWallet.TestTxService() + txService._addObserver = { _ in } + + let blockchainRegistry = BraveWallet.TestBlockchainRegistry() + blockchainRegistry._buyTokens = { + $2([.previewToken]) + } + blockchainRegistry._allTokens = { + $2([.previewToken]) + } + + let solTxManagerProxy = BraveWallet.TestSolanaTxManagerProxy() + let swapService = BraveWallet.TestSwapService() + + // setup store + var store = AssetDetailStore( + assetRatioService: assetRatioService, + keyringService: keyringService, + rpcService: rpcService, + walletService: walletService, + txService: txService, + blockchainRegistry: blockchainRegistry, + solTxManagerProxy: solTxManagerProxy, + swapService: swapService, + assetDetailType: .coinMarket(.mockCoinMarketBitcoin) + ) + + let assetDetailBitcoinException = expectation(description: "update-coinMarket-bitcoin") + assetDetailBitcoinException.expectedFulfillmentCount = 11 + store.$isBuySupported + .dropFirst() + .sink { + defer { assetDetailBitcoinException.fulfill() } + XCTAssertFalse($0) + } + .store(in: &cancellables) + store.$isSendSupported + .dropFirst() + .sink { + defer { assetDetailBitcoinException.fulfill() } + XCTAssertFalse($0) + } + .store(in: &cancellables) + store.$isSwapSupported + .dropFirst() + .sink { + defer { assetDetailBitcoinException.fulfill() } + XCTAssertFalse($0) + } + .store(in: &cancellables) + store.$btcRatio + .dropFirst() + .sink { + defer { assetDetailBitcoinException.fulfill() } + XCTAssertEqual($0, "1 BTC") + } + .store(in: &cancellables) + store.$priceHistory + .dropFirst() + .sink { priceHistory in + defer { assetDetailBitcoinException.fulfill() } + XCTAssertEqual(priceHistory.count, 1) + XCTAssertEqual(priceHistory[0].price, "0.99") + } + .store(in: &cancellables) + store.$price + .dropFirst() + .sink { + defer { assetDetailBitcoinException.fulfill() } + XCTAssertEqual($0, "$28,324.00") + } + .store(in: &cancellables) + store.$priceIsDown + .dropFirst() + .sink { + defer { assetDetailBitcoinException.fulfill() } + XCTAssertFalse($0) + } + .store(in: &cancellables) + store.$priceDelta + .dropFirst() + .sink { + defer { assetDetailBitcoinException.fulfill() } + XCTAssertEqual($0, "0.58%") + } + .store(in: &cancellables) + store.$isLoadingPrice + .dropFirst() + .collect(2) + .sink { values in + defer { assetDetailBitcoinException.fulfill() } + guard let value = values.last + else { + XCTFail("Unexpected isLoadingPrice") + return + } + XCTAssertFalse(value) + } + .store(in: &cancellables) + store.$isInitialState + .dropFirst() + .sink { + defer { assetDetailBitcoinException.fulfill() } + XCTAssertFalse($0) + } + .store(in: &cancellables) + store.$isLoadingChart + .dropFirst() + .collect(2) + .sink { values in + defer { + XCTAssertNil(store.network) + XCTAssertTrue(store.accounts.isEmpty) + XCTAssertTrue(store.transactionSummaries.isEmpty) + + assetDetailBitcoinException.fulfill() + } + guard let value = values.last + else { + XCTFail("Unexpected isLoadingChart") + return + } + XCTAssertFalse(value) + } + .store(in: &cancellables) + + store.update() + wait(for: [assetDetailBitcoinException], timeout: 1) + cancellables.removeAll() + + // setup store + store = AssetDetailStore( + assetRatioService: assetRatioService, + keyringService: keyringService, + rpcService: rpcService, + walletService: walletService, + txService: txService, + blockchainRegistry: blockchainRegistry, + solTxManagerProxy: solTxManagerProxy, + swapService: swapService, + assetDetailType: .coinMarket(.mockCoinMarketEth) + ) + let assetDetailNonBitcoinException = expectation(description: "update-coinMarket-non-bitcoin") + assetDetailNonBitcoinException.expectedFulfillmentCount = 11 + store.$isBuySupported + .dropFirst() + .sink { + defer { assetDetailNonBitcoinException.fulfill() } + XCTAssertTrue($0) + } + .store(in: &cancellables) + store.$isSendSupported + .dropFirst() + .sink { + defer { assetDetailNonBitcoinException.fulfill() } + XCTAssertFalse($0) + } + .store(in: &cancellables) + store.$isSwapSupported + .dropFirst() + .sink { + defer { assetDetailNonBitcoinException.fulfill() } + XCTAssertFalse($0) + } + .store(in: &cancellables) + store.$btcRatio + .dropFirst() + .sink { + defer { assetDetailNonBitcoinException.fulfill() } + XCTAssertEqual($0, "0.1 BTC") + } + .store(in: &cancellables) + store.$priceHistory + .dropFirst() + .sink { priceHistory in + defer { assetDetailNonBitcoinException.fulfill() } + XCTAssertEqual(priceHistory.count, 1) + XCTAssertEqual(priceHistory[0].price, "0.99") + } + .store(in: &cancellables) + store.$price + .dropFirst() + .sink { + defer { assetDetailNonBitcoinException.fulfill() } + XCTAssertEqual($0, "$1,860.57") + } + .store(in: &cancellables) + store.$priceIsDown + .dropFirst() + .sink { + defer { assetDetailNonBitcoinException.fulfill() } + XCTAssertTrue($0) + } + .store(in: &cancellables) + store.$priceDelta + .dropFirst() + .sink { + defer { + XCTAssertNil(store.network) + XCTAssertTrue(store.accounts.isEmpty) + XCTAssertTrue(store.transactionSummaries.isEmpty) + + assetDetailNonBitcoinException.fulfill() + } + XCTAssertEqual($0, "-0.23%") + } + .store(in: &cancellables) + store.$isLoadingPrice + .dropFirst() + .collect(2) + .sink { values in + defer { assetDetailNonBitcoinException.fulfill() } + guard let value = values.last + else { + XCTFail("Unexpected isLoadingPrice") + return + } + XCTAssertFalse(value) + } + .store(in: &cancellables) + store.$isInitialState + .dropFirst() + .sink { + defer { assetDetailNonBitcoinException.fulfill() } + XCTAssertFalse($0) + } + .store(in: &cancellables) + store.$isLoadingChart + .dropFirst() + .collect(2) + .sink { values in + defer { + XCTAssertNil(store.network) + XCTAssertTrue(store.accounts.isEmpty) + XCTAssertTrue(store.transactionSummaries.isEmpty) + + assetDetailNonBitcoinException.fulfill() + } + guard let value = values.last + else { + XCTFail("Unexpected isLoadingChart") + return + } + XCTAssertFalse(value) + } + .store(in: &cancellables) + + store.update() + wait(for: [assetDetailNonBitcoinException], timeout: 1) + } +}