From 6244a49a95d1112d9e3a4e54b37a6f353c4614d4 Mon Sep 17 00:00:00 2001 From: Max Karolinskiy Date: Fri, 7 Jun 2019 12:28:54 -0400 Subject: [PATCH] Commented out testonly attribute from chromedriver build files. Needed by //brave:brave_chromedriver_dist_resources Chromium change: commit 5c1bccba168c40684560b571a4004c2502791608 Author: Daniel Bratell Date: Tue Apr 23 17:37:02 2019 +0000 Fixing and enabling dependency checks for chromedriver Since we had a bug because of this missing check, let's not repeat it. Bug: 949535 --- patches/chrome-test-chromedriver-BUILD.gn.patch | 13 +++++++++++++ patches/net-traffic_annotation-BUILD.gn.patch | 13 +++++++++++++ 2 files changed, 26 insertions(+) create mode 100644 patches/chrome-test-chromedriver-BUILD.gn.patch create mode 100644 patches/net-traffic_annotation-BUILD.gn.patch diff --git a/patches/chrome-test-chromedriver-BUILD.gn.patch b/patches/chrome-test-chromedriver-BUILD.gn.patch new file mode 100644 index 000000000000..d5bd87f6e69b --- /dev/null +++ b/patches/chrome-test-chromedriver-BUILD.gn.patch @@ -0,0 +1,13 @@ +diff --git a/chrome/test/chromedriver/BUILD.gn b/chrome/test/chromedriver/BUILD.gn +index ab46b4e2de94f567e2f010f6badae325db24ac61..0929168b9f17b4aa2bdd6e721bf71af8909d90d0 100644 +--- a/chrome/test/chromedriver/BUILD.gn ++++ b/chrome/test/chromedriver/BUILD.gn +@@ -304,7 +304,7 @@ source_set("lib") { + } + + executable("chromedriver") { +- testonly = true ++# testonly = true + sources = [ + "server/chromedriver_server.cc", + ] diff --git a/patches/net-traffic_annotation-BUILD.gn.patch b/patches/net-traffic_annotation-BUILD.gn.patch new file mode 100644 index 000000000000..41896765b745 --- /dev/null +++ b/patches/net-traffic_annotation-BUILD.gn.patch @@ -0,0 +1,13 @@ +diff --git a/net/traffic_annotation/BUILD.gn b/net/traffic_annotation/BUILD.gn +index 771970a0462592317bcc061c7763eb55e67458df..66e73e69e4cf1e79ece8f49f59ad0c30f87647b2 100644 +--- a/net/traffic_annotation/BUILD.gn ++++ b/net/traffic_annotation/BUILD.gn +@@ -8,7 +8,7 @@ source_set("traffic_annotation") { + } + + source_set("test_support") { +- testonly = true ++# testonly = true + sources = [ + "network_traffic_annotation_test_helper.h", + ]