From 1c38e678938f4302ee419515862a0e14649c630f Mon Sep 17 00:00:00 2001 From: Brian Clifton Date: Fri, 9 Jul 2021 01:23:28 -0700 Subject: [PATCH] Update search engine onboarding screen Fixes https://github.com/brave/brave-browser/issues/16825 --- browser/ui/webui/brave_webui_source.cc | 1 - .../components/images/welcome_search.svg | 380 +++++++++--------- .../containers/screens/searchBox.tsx | 7 +- .../resources/brave_components_strings.grd | 1 - 4 files changed, 192 insertions(+), 197 deletions(-) diff --git a/browser/ui/webui/brave_webui_source.cc b/browser/ui/webui/brave_webui_source.cc index d551fbf6fce5..6c2038a3063e 100644 --- a/browser/ui/webui/brave_webui_source.cc +++ b/browser/ui/webui/brave_webui_source.cc @@ -443,7 +443,6 @@ void CustomizeWebUIHTMLSource(const std::string &name, { "setDefaultSearchEngine", IDS_BRAVE_WELCOME_PAGE_SEARCH_TITLE }, { "chooseSearchEngine", IDS_BRAVE_WELCOME_PAGE_SEARCH_DESC }, { "selectSearchEngine", IDS_BRAVE_WELCOME_PAGE_SEARCH_SELECT }, - { "privateExperience", IDS_BRAVE_WELCOME_PAGE_PRIVATE_EXPERIENCE_DESC }, { "skipWelcomeTour", IDS_BRAVE_WELCOME_PAGE_SKIP_BUTTON }, { "next", IDS_BRAVE_WELCOME_PAGE_NEXT_BUTTON }, { "done", IDS_BRAVE_WELCOME_PAGE_DONE_BUTTON }, diff --git a/components/brave_welcome_ui/components/images/welcome_search.svg b/components/brave_welcome_ui/components/images/welcome_search.svg index 03909fbf3b99..7bf626c2df3f 100644 --- a/components/brave_welcome_ui/components/images/welcome_search.svg +++ b/components/brave_welcome_ui/components/images/welcome_search.svg @@ -1,189 +1,191 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/components/brave_welcome_ui/containers/screens/searchBox.tsx b/components/brave_welcome_ui/containers/screens/searchBox.tsx index f007d99950ba..1b46b6390ba6 100644 --- a/components/brave_welcome_ui/containers/screens/searchBox.tsx +++ b/components/brave_welcome_ui/containers/screens/searchBox.tsx @@ -56,17 +56,12 @@ export default class SearchEngineBox extends React.PureComponent { ? `${searchProvider.name} (${getLocale('default')})` : searchProvider.name - getBodyText = (searchProviderName: string): string => - searchProviderName === 'Google' - ? `${getLocale('chooseSearchEngine')} ${getLocale('privateExperience')}` - : getLocale('chooseSearchEngine') - render () { const { index, currentScreen, onClick, searchProviders } = this.props const { searchEngineSelected } = this.state const defaultProvider = this.getDefaultSearchProvider(searchProviders) const bodyText = defaultProvider - ? this.getBodyText(defaultProvider.name) || '' + ? getLocale('chooseSearchEngine') || '' : '' return ( diff --git a/components/resources/brave_components_strings.grd b/components/resources/brave_components_strings.grd index 39401192c8e4..842943419604 100644 --- a/components/resources/brave_components_strings.grd +++ b/components/resources/brave_components_strings.grd @@ -382,7 +382,6 @@ Select a search engine Choose the search engine you would like to use by default when searching the web from the address bar. Set default search engine - For a more private search experience, try DuckDuckGo. Skip welcome tour Next Done