Copying our pre-generated midl files to overwrite upstream midl files #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
simonhong
changed the title
simonhong
force-pushed
the
copying_midl_files
branch
from
c1ea23b to
f7c8741
Compare
…iles Chromium compares pre-installed midl files and generated midl files from IDL file during the build to check integrity. In our case, generated files during the build time and pre-installed upstream files(in src/third_party/win_build_outout/midl/google_update) are different because we use different IDL file (src/brave/chromium_src/google_update/google_update_idl.idl) for google update. To pass this integrity check in the build phase, we should copy our pre-installed files to overwrite upstream files. Also, these files should not be the target of update_patches command.
simonhong
force-pushed
the
copying_midl_files
branch
from
f7c8741 to
79f70c9
Compare
bbondy
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromum compares pre-installed midl files and generated midl files from
IDL file during the build to check integrity.
Generated files during the build time and upstream generated files are
different because we use different IDL file(google_update_idl.idl) for google update.
So, we should copy our pre-installed files to overwrite upstream
pre-installed files.
Also, these files should not be the target of update_patches command.
issue: #179
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: