Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition Brave Ads prefs from the service layer to bat-native-ads #9999

Closed
tmancey opened this issue May 29, 2020 · 1 comment · Fixed by brave/brave-core#6715
Closed

Transition Brave Ads prefs from the service layer to bat-native-ads #9999

tmancey opened this issue May 29, 2020 · 1 comment · Fixed by brave/brave-core#6715
Assignees
@tmancey
Labels
dev-concern feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.17.x - Release #1

Comments

@tmancey
Copy link
Contributor

tmancey commented May 29, 2020 •
edited
Loading

Transition Brave Ads prefs from the service layer to bat-native-ads using Get<Type>Pref, i.e. GetBooleanPref, GetStringPref etc.
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. dev-concern QA/Yes release-notes/exclude feature/ads labels May 29, 2020
@tmancey tmancey mentioned this issue May 29, 2020
Closed
@moritzhaller moritzhaller mentioned this issue Aug 3, 2020
Closed
@tmancey tmancey added OS/Android Fixes related to Android browser functionality OS/Desktop and removed QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 5, 2020
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude OS/Desktop labels Aug 20, 2020
@tmancey tmancey self-assigned this Sep 23, 2020
@tmancey tmancey mentioned this issue Sep 28, 2020
Merged
32 tasks
@tmancey tmancey added this to the 1.17.x - Nightly milestone Sep 30, 2020
@kjozwiak
Copy link
Member

Labeling this one as QA/No as brave/brave-core#6872 will basically cover most of these cases. The remaining cases mentioned in brave/brave-core#6872 will also be covered via our manual passes.

@kjozwiak kjozwiak added QA/No and removed QA/Yes labels Nov 12, 2020
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
dev-concern feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.17.x - Release #1
Development

Successfully merging a pull request may close this issue.

Transition Brave Ads prefs from the service layer to bat-native-ads brave/brave-core
4 participants
@tmancey @moritzhaller @kjozwiak and others