Tab border refinement #962
Assignees
Labels
Milestone
Comments
petemill
added a commit
to brave/brave-core
that referenced
this issue
Sep 7, 2018
Fix brave/brave-browser#962 Brave design spec shows no bottom border radius on tabs. This patching method, although not great, is simple compared to the amount of code which would need to be copied over and only slightly modified.
11 tasks
|
Removed pr/pending-review since PR seems to still be work in progress. I think that label makes it sound like it's waiting on a review. |
|
Agreed @bbondy. I had submitted for review but then removed whilst I refactor. |
petemill
added a commit
to brave/brave-core
that referenced
this issue
Sep 13, 2018
Fix brave/brave-browser#962 Brave design spec shows no bottom border radius on tabs. This patching method, although not great, is simple compared to the amount of code which would need to be copied over and only slightly modified.
petemill
added a commit
to brave/brave-core
that referenced
this issue
Sep 13, 2018
|
@petemill could you help with a test plan for this one? |
|
Test plan added |
|
Verification Passed on
Verified passed with
Verification Passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
brave/brave-core#391 covers changing the tab border radii, but does not deal with the bottom border radius, which needs to be removed according to the spec.
We also need to implement the changes to the tab separator - it gets thicker, taller, and aligned to the bottom.
Test plan
Observe left border of tab ends at the bottom with 90degree angle. In other words, no border radius, as in screenshot above.
The text was updated successfully, but these errors were encountered: