Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom cosmetic filter rules should be applied irregardless of 1p or 3p status #9577

Closed
pes10k opened this issue May 1, 2020 · 1 comment
Assignees
Labels
closed/invalid feature/shields The overall Shields feature in Brave. features/shields/cosmetic-filtering privacy-pod Feature work for the Privacy & Web Compatibility pod

Comments

@pes10k
Copy link
Contributor

pes10k commented May 1, 2020

Currently cosmetic custom filter rules go through the same 1p vs 3p check that rules pulled from filter lists go through.

This should be changed so that custom filter list rules are always applied, independent of 1p vs 3p determination.

This would have the additional benefit of allowing us to move the rules from the "right click and hide" functionality to be custom filter rules, and unify the two systems (and avoid the duplicate MutationObservers)

@pes10k pes10k added feature/shields The overall Shields feature in Brave. features/shields/cosmetic-filtering privacy-pod Feature work for the Privacy & Web Compatibility pod labels May 1, 2020
@antonok-edm
Copy link
Collaborator

This is actually already supported!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/invalid feature/shields The overall Shields feature in Brave. features/shields/cosmetic-filtering privacy-pod Feature work for the Privacy & Web Compatibility pod
Projects
None yet
Development

No branches or pull requests

3 participants