Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Hide Top Sites on NTP Top sites is misaligned in Polish locale #9497

Closed
btlechowski opened this issue Apr 28, 2020 · 3 comments
Closed
Labels

Comments

@btlechowski
Copy link

Follow up to #9267

Steps to Reproduce

  1. Open Brave in Polish locale
  2. Add pages to NTP Top Sites
  3. Hover over NTP Top Sites widget
  4. Show Hide Top Sites

Actual result:

In polish locale Hide Top Sites is misaligned
image

Expected result:

In polish locale Hide Top Sites is aligned properly

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @cezaraugusto @ryanml @rebron

@btlechowski
Copy link
Author

Still reproducible

Brave 1.11.35 Chromium: 83.0.4103.61 (Official Build) nightly (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS Windows 7 Service Pack 1 (Build 7601.24544)

image

@rebron rebron added l10n priority/P3 The next thing for us to work on. It'll ride the trains. OS/Desktop labels Jun 3, 2020
@srirambv srirambv changed the title Hide Top Sites on NTP Top sites is misaligned in Polish locale [Desktop] Hide Top Sites on NTP Top sites is misaligned in Polish locale Sep 9, 2020
@ryanml
Copy link
Contributor

ryanml commented Oct 6, 2020

@bbondy
Copy link
Member

bbondy commented Oct 13, 2020

If this is closed by the above PR pls specify the milestone where the code landed. If it's just a duplicate please just label as closed/duplicate.

@ryanml ryanml added the closed/duplicate Issue has already been reported label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants