Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] WebRTC test fails #9041

Closed
srirambv opened this issue Apr 6, 2020 · 11 comments
Closed

[Android] WebRTC test fails #9041

srirambv opened this issue Apr 6, 2020 · 11 comments
Labels
closed/invalid OS/Android Fixes related to Android browser functionality

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 6, 2020

Description

WebRTC test fails

Steps to reproduce

Upgrade

  1. Install 1.5.9 and enable fingerprinting, ensure 2 items are blocked
  2. Upgrade to 1.5.120, fingerprinting fails. IP address is shown
  3. Upgrade to 1.5.130, fingerprinting still fails

Clean Install

  1. Clean install 1.5.130
  2. Visit https://browserleaks.com/webrtc
  3. IP address is shown and not blocked

Actual result

image

Expected result

WebRTC should be blocked by default

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? Yes on 1.5.120
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.5.9 - Blocked
1.5.120 - Not Blocked
1.5.130 - Not Blocked

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

No

@srirambv srirambv added bug feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields regression OS/Android Fixes related to Android browser functionality labels Apr 6, 2020
@srirambv srirambv added this to the Android 1.5.x Hotfix Release milestone Apr 6, 2020
@samartnik samartnik self-assigned this Apr 8, 2020
@samartnik
Copy link
Contributor

Unlike android-tabs, on brave-core we block only 3rd party fingerprinting. We need new design to add ability to set blocking fingerprinting and cookies fully.
cc @anthonypkeane @jamesmudgett

@anthonypkeane
Copy link

@karenkliu has a design for that and it is detailed here: #6831

Can you cherry pick the design you need from #6831? If not please LMK and a specific design can be added here.

@karenkliu
Copy link

@samartnik
shields subpanels

@SergeyZhukovsky
Copy link
Member

we are going to redo the shields UI and add appropriate controls

@srirambv
Copy link
Contributor Author

srirambv commented May 4, 2020

+1 from https://community.brave.com/t/unable-to-disable-webrtc-in-brave-android/122548/2 for not able to disable WebRTC on Android

@SergeyZhukovsky SergeyZhukovsky removed this from the Android 1.8.x Release milestone May 6, 2020
@SergeyZhukovsky
Copy link
Member

That will be fixed in context of that issue #6831

@samartnik samartnik removed their assignment May 11, 2020
@anthonypkeane
Copy link

@kjozwiak can you please re-test

@srirambv
Copy link
Contributor Author

This is still an issue. Irrespective of Fingerprinting settings (standard/strict) IP address is still shown. On the contrary desktop blocks it irrespective of FP setting

@SergeyZhukovsky SergeyZhukovsky added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 3, 2021
@waynea
Copy link

waynea commented Mar 24, 2021

This issue is still live - has there been any progress towards a fix?

@srirambv srirambv removed their assignment Mar 24, 2021
@samartnik
Copy link
Contributor

samartnik commented Apr 26, 2021

@srirambv is it still an issue? WebRTC is not tied to fingerprinting option anymore, but controlled by WebRTC IP handling policy option.

@srirambv
Copy link
Contributor Author

@srirambv srirambv added closed/invalid and removed bug feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields priority/P2 A bad problem. We might uplift this to the next planned release. regression labels Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/invalid OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

8 participants
@karenkliu @kjozwiak @anthonypkeane @SergeyZhukovsky @srirambv @waynea @samartnik and others