-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up of #2400 - Shields settings is lost after clearing data and relaunching #8813
Labels
Comments
GeetaSarvadnya
added
bug
feature/shields
The overall Shields feature in Brave.
priority/P2
A bad problem. We might uplift this to the next planned release.
QA/Yes
QA/Test-Plan-Specified
labels
Mar 23, 2020
Test plan from original fix(brave/brave-core#4361) mentions a new setting in
|
is it fixed now? |
This is the correct behavior and is a duplicate of #2400 |
bridiver
added
closed/invalid
closed/duplicate
Issue has already been reported
and removed
closed/invalid
labels
Mar 24, 2020
GeetaSarvadnya
removed
QA/Test-Plan-Specified
QA/Yes
bug
closed/duplicate
Issue has already been reported
feature/shields
The overall Shields feature in Brave.
priority/P2
A bad problem. We might uplift this to the next planned release.
labels
Mar 24, 2020
@bridiver it clearly said "follow up" |
as per the comments #2400 (comment) - Issue is invalid marking it as invalid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Found while testing #2400
Follow up of #2400 - Shields settings is lost after clearing data and relaunching
Steps to Reproduce
Actual result:
Shields settings is lost after clearing data and relaunching
Expected result:
Clear data shouldn't reset shields settings
Reproduces how often:
Easy
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/legacy_qa @simonhong @tomlowenthal @diracdeltas @bbondy
The text was updated successfully, but these errors were encountered: