Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #2400 - Shields settings is lost after clearing data and relaunching #8813

Closed
GeetaSarvadnya opened this issue Mar 23, 2020 · 5 comments

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #2400

Follow up of #2400 - Shields settings is lost after clearing data and relaunching

Steps to Reproduce

  1. Visit brave.com and disable shields
  2. Visit github.com and change site shields settings from default to custom
  3. Clear browsing data from all time and select all checkboxes
  4. Restart browser after data is cleared
  5. Open brave.com, shields is auto-enabled
  6. Open github.com, site shields settings are lost and reverted back to default settings

Actual result:

Shields settings is lost after clearing data and relaunching

Expected result:

Clear data shouldn't reset shields settings

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.7.67 Chromium: 80.0.3987.149 (Official Build) beta (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @simonhong @tomlowenthal @diracdeltas @bbondy

@GeetaSarvadnya GeetaSarvadnya added bug feature/shields The overall Shields feature in Brave. priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes QA/Test-Plan-Specified labels Mar 23, 2020
@GeetaSarvadnya GeetaSarvadnya added this to the 1.7.x - Beta milestone Mar 23, 2020
@btlechowski
Copy link

Test plan from original fix(brave/brave-core#4361) mentions a new setting in Clear browsing data. It is missing.

Brave 1.7.70 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

image

@ze0ss
Copy link

ze0ss commented Mar 24, 2020

is it fixed now?
did u commit?

@bridiver
Copy link
Contributor

This is the correct behavior and is a duplicate of #2400

@bridiver bridiver added closed/invalid closed/duplicate Issue has already been reported and removed closed/invalid labels Mar 24, 2020
@GeetaSarvadnya GeetaSarvadnya removed QA/Test-Plan-Specified QA/Yes bug closed/duplicate Issue has already been reported feature/shields The overall Shields feature in Brave. priority/P2 A bad problem. We might uplift this to the next planned release. labels Mar 24, 2020
@GeetaSarvadnya GeetaSarvadnya removed this from the 1.7.x - Beta milestone Mar 24, 2020
@ze0ss
Copy link

ze0ss commented Mar 24, 2020

@bridiver it clearly said "follow up"

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Mar 24, 2020

as per the comments #2400 (comment) - Issue is invalid marking it as invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants