Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing creative set segments and unknown types in the Brave Ads catalog should not fail to parse the catalog #8799

Closed
tmancey opened this issue Mar 21, 2020 · 2 comments · Fixed by brave/brave-core#5003
Closed

Missing creative set segments and unknown types in the Brave Ads catalog should not fail to parse the catalog #8799

tmancey opened this issue Mar 21, 2020 · 2 comments · Fixed by brave/brave-core#5003
Assignees
@tmancey
Labels
enhancement feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.8.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 21, 2020 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#5003

Description

Missing creative set segments and invalid types in the Brave Ads catalog should not fail to parse the catalog.
@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes feature/ads labels Mar 21, 2020
@tmancey tmancey self-assigned this Mar 21, 2020
@tmancey tmancey added bug and removed enhancement labels Mar 21, 2020
@tmancey tmancey changed the title Missing creative set segments in the Brave Ads catalog should default Missing creative set segments and invalid types in Brave Ads catalog should not fail to parse the catalog Mar 21, 2020
@tmancey tmancey changed the title Missing creative set segments and invalid types in Brave Ads catalog should not fail to parse the catalog Missing creative set segments and invalid types in the Brave Ads catalog should not fail to parse the catalog Mar 21, 2020
@tmancey tmancey changed the title Missing creative set segments and invalid types in the Brave Ads catalog should not fail to parse the catalog Missing creative set segments and unknown types in the Brave Ads catalog should not fail to parse the catalog Mar 21, 2020
@tmancey tmancey mentioned this issue Mar 21, 2020
Merged
32 tasks
@tmancey tmancey added enhancement and removed bug labels Mar 21, 2020
@tmancey tmancey added this to the 1.8.x - Nightly milestone Mar 22, 2020
@bsclifton
Copy link
Member

Added link to test plan - @tmancey is this something we'd want to call out in release notes? (if not, can you please add release-notes/exclude)

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 17, 2020 •
edited by btlechowski
Loading

Verification passed on

Brave 1.8.77 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

Verified passed using

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)

Verification passed on

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Ubuntu 18.04 LTS

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.8.x - Release
5 participants
@tmancey @bsclifton @LaurenWags @btlechowski @GeetaSarvadnya