Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Already sustaining ad notification interaction is shown for conversion of the second ad within the same creative set #8634

Closed
btlechowski opened this issue Mar 11, 2020 · 1 comment · Fixed by brave/brave-core#4906

Comments

@btlechowski
Copy link

btlechowski commented Mar 11, 2020

Found while testing #6536.
The conversion queue should be empty after trying the conversion of another ad with the same creative set id

Steps to Reproduce

  1. Watch an ad
  2. Convert the ad
  3. Watch a second ad with the same creativeSetId
  4. Convert the second ad
  5. Watch logs

Note: reproduced on staging

Actual result:

Already sustaining ad notification interaction for https://travala.com/booking?check_in=*

Expected result:

Ads conversion queue is empty

Reproduces how often:

50% repro rate

Brave version (brave://version info)

Brave 1.7.54 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS
Brave 1.7.54 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa @tmancey @jsecretan @rebron

@btlechowski
Copy link
Author

btlechowski commented Apr 23, 2020

Verification passed on

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Ubuntu 18.04 LTS

Test plan used:

  1. Overwrite the catalog with Charles
    Catalog:
    8634.txt
  2. Run Brave with command line: /usr/bin/brave-browser-dev --enable-logging=stderr --vmodule=brave_ads=3 --brave-ads-staging --rewards=staging=true
  3. Enable Rewards
  4. Open brave.com and trigger an ad
  5. Click on the ad
  6. Wait for the ad conversion confirmation
  7. Open brave.com and trigger an ad
  8. Click on the ad

Expected behavior:
Already sustaining ad notification interaction for is not in the logs

Verified above test plan.

Logged #9412


Verified passed with

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)

Verification passed on

Brave 1.8.84 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan outlined above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment