Light/Dark should be selectable in development

[petemill]

brave/brave-core#351 introduced theme preference for built-in light / dark but did not remove the compiler flag which forces dark theme in development. This should be selectable on any build, and only the default is different.

[btlechowski]

Verification passed on

Brave	0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Windows 7

Verification Passed on

Brave	0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave (master)	0.55.2 Chromium: 70.0.3538.22 (Developer Build) (64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}

Kamils-MBP:brave-browser kjozwiak$ git log -1
commit 4278f5e9ba407a4d5e632c049e1b3b9175c243c4 (HEAD -> master, origin/master, origin/HEAD)
Merge: a6b443c ce9099e
Author: Brian Clifton <[email protected]>
Date:   Mon Sep 24 11:49:13 2018 -0700

    Merge pull request #1244 from brave/brave-referrals-api-key-config

    Add brave_referrals_api_key to build config

Ensured that the following cases passed:

• launched brave via npm start and ensured Default was selected as the theme
• selected Light and ensured that the theme changed (restarted and ensured it was selected)
• selected Dark and ensured that the theme changed (restarted and ensured it was selected)
• rm -rf ~/Library/Application\ Support/BraveSoftware/Brave-Browser-Development/, relaunched using npm start and ensured that Default was selected.

[kjozwiak]

@btlechowski @srirambv was this checked against a local development build that was created from source? Double checked with @petemill who mentioned this is supposed to be tested with a local build. Just double checking to make sure we didn't test this against build that has already been released.

[srirambv]

@kjozwiak I've verified it on Windows from source. Will update once build finishes on Linux

[srirambv]

@kjozwiak verified on Linux as well the command line flag works with development folder. Just a note, only the URL bar colour changes for Linux when switching between Light and Dark and other chrome elements retain the GTK colour scheme

[kjozwiak]

Thanks @srirambv 👍