Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrome://welcome-win10 is displayed on Windows #86

Closed
bbondy opened this issue Mar 1, 2018 · 2 comments
Closed

chrome://welcome-win10 is displayed on Windows #86

bbondy opened this issue Mar 1, 2018 · 2 comments
Labels
bug OS/Windows QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Mar 1, 2018

No description provided.

@bbondy bbondy added the bug label Mar 1, 2018
@srirambv
Copy link
Contributor

srirambv commented Mar 1, 2018

Consolidated list of all welcome screens on Windows in #87

@srirambv srirambv closed this as completed Mar 1, 2018
@bbondy bbondy added this to the Releasable builds milestone Jun 14, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 28, 2018 •
edited by kjozwiak
Loading

This page is removed with chrome://welcome. Verified on:

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
  • Verified not chrome://welcome-win10 navigates to chrome://welcome on Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
  • Verified that chrome://welcome/ was being used and not chrome://welcome-win10 (even though it's a Win related issue)

@bbondy bbondy added the QA/Yes label Sep 27, 2018
@pixmix pixmix mentioned this issue Feb 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug OS/Windows QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
4 participants
@bbondy @kjozwiak @srirambv @GeetaSarvadnya