Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner request: Sliver.tv has rebranded as Theta.tv #8201

Closed
lukemulks opened this issue Feb 12, 2020 · 3 comments
Closed

Partner request: Sliver.tv has rebranded as Theta.tv #8201

lukemulks opened this issue Feb 12, 2020 · 3 comments

Comments

@lukemulks
Copy link

Description

We announced a partnership with Sliver.tv in July 2019.
As part of the partnership, Sliver.tv had made Brave their recommended browser.
There were a few items we had to work on to:

  1. allow for autoplay on sliver.tv in Brave (Add sliver.tv to whitelist autoplay-whitelist#15)

and

  1. allow for people to earn their TFuel token while watching streams. (Errors related to TFuel collection on sliver.tv #5380)

Sliver.tv has recently been rebranded as https://www.theta.tv/, and they've requested that we apply the same adjustments we made for Sliver.tv for Theta.tv so they can continue to promote Brave to their audience.

The work/steps required for both requests are in both of the linked issues above, and should (hopefully) be the same, only with the name changed from sliver.tv to theta.tv.

Any assistance in getting this completed would be greatly appreciated. I can post a separate issue in the autoplay-whitelist repo as well, if that would be helpful.

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron rebron self-assigned this Feb 18, 2020
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. feature/autoplay labels Feb 18, 2020
@rebron
Copy link
Collaborator

rebron commented Apr 28, 2020

For 1. Allow list for autoplay has been removed completely via #8408

For 2. @pes10k There was a name change from Sliver.tv to Theta.tv, so it looks like need an update here: brave/brave-core@7626c3d

@rebron rebron assigned pes10k and unassigned rebron Apr 28, 2020
@pes10k
Copy link
Contributor

pes10k commented Apr 28, 2020

@rebron we don't currently have any remaining exceptions for sliver.tv, they're no longer needed because of other fixes (you can see that in the current version of the file you linked to at https://github.com/brave/brave-core/blob/8d5f062c6a53b1d8d699eb57fa3aad310389aa24/common/shield_exceptions.cc).

So, i think nothing to do here. Close?

@rebron
Copy link
Collaborator

rebron commented Apr 28, 2020

Closing. @lukemulks Due to other fixes, Sliver.tv/Theta.tv shouldn't need any exceptions to work properly.

Thanks for confirming @pes10k

@rebron rebron closed this as completed Apr 28, 2020
@rebron rebron added closed/invalid and removed feature/autoplay priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants