Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable translate without user-interaction #812

Closed
jumde opened this issue Aug 22, 2018 · 3 comments · Fixed by brave/brave-core#573
Closed

Disable translate without user-interaction #812

jumde opened this issue Aug 22, 2018 · 3 comments · Fixed by brave/brave-core#573

Comments

@jumde
Copy link
Contributor

jumde commented Aug 22, 2018

Description

Disable translate by default. On visiting a domain with a different language preference, a request is initiated for translate.googleapis.com without user-interaction

Steps to Reproduce

  1. Open https://espanol.epa.gov/ and a dialog to translate the page is displayed

Actual result:

The translate dialog is displayed and request to translate.googleapis.com is initiated.

Expected result:

The request should only be initiated on user-interaction.

Reproduces how often:

100%

Brave version (about:brave info)

0.54.0 Chromium: 69.0.3497.32 (Official Build) dev (64-bit)

Reproducible on current release:

Yes

@tildelowengrimm
Copy link
Contributor

Perhaps it would make sense to have an off-by-default pref to turn this back on. It's a useful feature which has a privacy cost. Some might want it on, some off — we should ship it off and lets folks turn it back on?

@srirambv
Copy link
Contributor

I think #208 supersedes this issue.

@srirambv srirambv added this to the Backlog milestone Aug 23, 2018
@tildelowengrimm tildelowengrimm added privacy privacy/connect This requires making a network connection to a third-party service. labels Sep 15, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, 1.0 (0.56.x) Oct 1, 2018
@bbondy bbondy modified the milestones: 1.0 (0.56.x), Releasable builds 0.55.x Oct 5, 2018
@bbondy bbondy added the QA/Yes label Oct 5, 2018
@srirambv
Copy link
Contributor

srirambv commented Oct 9, 2018

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux
  • Verified visiting the specified link doesn't offer to translate to English
  • Verified other non-English sites don't offer to translate either

Verified passed with

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X
  • Verified visiting the specified link doesn't offer to translate to English
  • Verified other non-English sites don't offer to translate either

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows
  • Verified visiting the specified link doesn't offer to translate to English
  • Verified other non-English sites don't offer to translate either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants