Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Page Rewards Widget re-style #7885

Closed
petemill opened this issue Jan 23, 2020 · 1 comment · Fixed by brave/brave-core#4075
Closed

New Tab Page Rewards Widget re-style #7885

petemill opened this issue Jan 23, 2020 · 1 comment · Fixed by brave/brave-core#4075

Comments

@petemill
Copy link
Member

Description

For the New Tab Page Branded Wallpapers feature, most of the Rewards widget was re-styled. This includes colors, strings, spacing and some layout.

Actual result:

Pre opt-in

image

Opted in without Ads

image

Post opt-in

image

Notification

image

Expected result:

Pre opt-in

image

Opted in without Ads

image

Post opt-in

image

Notification

image

Reproduces how often:

Brave version (brave://version info)

1.5.42

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes
@LaurenWags
Copy link
Member

LaurenWags commented Feb 4, 2020

Verified passed with

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)

pre-opt in to Rewards (ever):
pre-opt in

re-opt in to Rewards (after it had been toggled off):
re-opt in

opted in with Ads toggled off:
opt in without ads

opted into everything (with values to show it populated):
post opt in with values

notification on widget:
UGP grant notification

Verification passed on

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Windows 10 OS Version 1803 (Build 17134.1006)

pre-opt in to Rewards (ever):
image

re-opt in to Rewards (after it had been toggled off):
image

opted in with Ads toggled off:
image

opted into everything (with values to show it populated):
image

claim notification on widget:
image

Verification passed on

Brave 1.3.111 Chromium: 80.0.3987.85 (Official Build) (64-bit)
Revision 583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS Ubuntu 18.04 LTS

pre-opt in to Rewards (ever):
image

re-opt in to Rewards (after it had been toggled off):
image

opted in with Ads toggled off:
image

claim notification on widget:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment