Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields extra padding show up when clicked on blocked count #771

Closed
srirambv opened this issue Aug 18, 2018 · 4 comments · Fixed by brave/brave-extension#78
Closed

Shields extra padding show up when clicked on blocked count #771

srirambv opened this issue Aug 18, 2018 · 4 comments · Fixed by brave/brave-extension#78

Comments

@srirambv
Copy link
Contributor

Description

As a follow up to #222

Steps to Reproduce

  1. Build from master
  2. Open any page with blocked count
  3. Click on blocked item in shields to expand view, shields panel expands and shows extra padding
  4. No extra padding shown when the block item is collapsed

Actual result:

shields

Expected result:

Should not show extra padding irrespective of expanding the blocked item view

Reproduces how often:

100%

Brave version (about:brave info)

Brave 0.55.1 Chromium: 69.0.3497.42 (Official Build) (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows
JavaScript V8 6.9.427.14
Flash (Disabled)

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @lukemulks based on #222 (comment)

@btlechowski
Copy link

Extra padding in not shown even when clicked on blocked element
222_pass

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

@cezaraugusto
Copy link
Contributor

@srirambv per @btlechowski last screenshot this seems to be solved. is this still an issue?

@LaurenWags
Copy link
Member

LaurenWags commented Nov 2, 2018

Verified passed with

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X
  • Verified shields design is updated and when expanding blocked items with new shields design, extra padding is not displayed.

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux
  • Verified clicking on block count doesn't show extra padding on the new shields design

Verification passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows
  • Verified clicking on bloacked content is not showing extra padding on new shield

image

@kjozwiak
Copy link
Member

kjozwiak commented Nov 5, 2018

Because this was fixed with the new shield design, labelling this as release-notes/exclude. #1339 will cover the new shield design in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment