Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: make pinned tabs stick to one site (like Safari) #7423

Open
kikujiro-mms opened this issue Dec 17, 2019 · 3 comments
Open

Suggestion: make pinned tabs stick to one site (like Safari) #7423

kikujiro-mms opened this issue Dec 17, 2019 · 3 comments
Labels
feature/pinned-tabs feature-request priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@kikujiro-mms
Copy link

This is a suggestion/request, not a bug.

In Brave, pinned tabs behave like normal tabs, in that opening a link from site A takes you to site B in the same tab. By contrast, in Safari, pinned tabs are specific to a site: opening a link to another site, or typing in a different URL, will open the new site in a new, non-pinned tab.

The Safari behaviour is imho vastly preferable, as it enables the user to keep frequently-used sites (e.g. webmail) permanently available. Brave's implementation as it stands just gives you a smaller tab pinned to the left with no stability of content.

So: please mimic the Safari behaviour.

Thanks

@bsclifton
Copy link
Member

Thanks for the report, @kikujiro-mms! I had reported this with #882 but I think you did a better job of describing. Will close my issue in favor of this one 😄

@bsclifton
Copy link
Member

From #882

Carried over from brave/browser-laptop#569

When I pin a tab, I want links to other sites to open in a new tab and only on-site links to open in the pinned tab. For example, if I pin gmail, I want to be able to navigate around gmail in that pinned tab but I want a link in an email to some other site to open in a new tab.

Steps to reproduce

  1. Visit https://media.clifton.io/issue-569/2016-05-27-brave-pin.html
  2. Pin the site
  3. Click the "same domain" link, notice it works as expected (opens in same tab)
  4. Click back
  5. Click the "external link"
  6. Notice it didn't work; it opens in the same tab

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Feb 14, 2020
@rebron
Copy link
Collaborator

rebron commented Feb 14, 2020

UE for this isn't straightforward. Inconsistent behavior with how sites what you to open new tab/links.

@rebron rebron moved this to P5 backlog in Front End May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/pinned-tabs feature-request priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Status: P5 backlog
Development

No branches or pull requests

3 participants