-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more zoom levels, like 133% #6943
Comments
I assume this won't be too hard - I'd like to get into supporting this project so would like to grab this |
edit: Changes need to be made in brave-core to adjust default zoom levels |
Fix was trivial but involved creating patches to update constants in chromium source code |
Created https://bugs.chromium.org/p/chromium/issues/detail?id=1030344 to upstream a proper fix for getting the constants in one place (using knowledge gained when helping with brave/brave-core#4092) |
Upstreamed a fix that will make changing this very easy (meaning we can remove the overrides if it's accepted): |
And here's the accepted fix, merged into upstream Chromium! 😄 Once we're using this version (master/Canary is 81), we can revert brave/brave-core#4092 except for |
awesome! |
@bsclifton question about the test plan - on step 6, should I be zooming on the Print Preview dialog? the macOS dialog print preview for PDF does have a Custom scale section, but it defaults to 100 and isn't limited to the browser zoom settings 110, 125, 133, etc. I set it to 103 below just to show that it increments/decrements by 1. |
@LaurenWags ah - good catch there. Testing that is not trivial, which I found out later when comitting some related changes upstream When you're on that page, the scale is not affecting zoom. You have to use the mouse to hover over the left and use the + and - buttons. Unfortunately, it doesn't say the % However, you can right click the preview itself and then pick Let me update the test plan... |
Verification passed on
Verified passed with
Verification passed on
|
Test plan
See brave/brave-core#4092
Description
Currently there's pretty big jumps in the zoom levels, going from 125% to 150% for example, so users want other zoom levels in between like 133%.
For reference:
https://www.reddit.com/r/IAmA/comments/dwfbmf/im_brendan_eich_inventor_of_javascript_and/f7karn6/
This matches Chrome but it's some low hanging fruit and should be an easy change.
Steps to Reproduce
Actual result:
It skips from 125% to 150%
Expected result:
More zoom levels, like 133%
Reproduces how often:
Always
Brave version (brave://version info)
All
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: