Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle distilled page content option is shown in all types of windows #6933

Closed
GeetaSarvadnya opened this issue Nov 14, 2019 · 2 comments
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 14, 2019

Description

By default the Toggle distilled page content option is shown in all types of windows in brave. In chrome, the option is shown in the hamburger menu only when the extension is enabled from chrome://flags, after enabling reader mode extension, the toggle distilled page content option is shown in all the windows in chrome ( Normal/Guest/ incognito)

Steps to Reproduce

  1. Open brave 0.72.x
  2. Open Normal window or Guest window or Private window or Private window with Tor
  3. Click on the hamburger menu
  4. Toggle distilled page content option is shown in all types of windows

Actual result:

Toggle distilled page content option is shown in all types of windows
image

Expected result:

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Even after enabling reader view extension in brave://flags the page content is not displayed in the reader view could be related to #679

cc: @brave/legacy_qa @rebron @bsclifton

@bsclifton
Copy link
Member

bsclifton commented Nov 15, 2019

cc: @petemill who hid this before in C77 with brave/brave-core#3397 (original issue was #5951)

edit: disregard this! Didn't realize it was a menu item (thought the UI had regressed)

@rebron
Copy link
Collaborator

rebron commented Nov 19, 2019

Closing. We're keeping the menu item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants