Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Window does not say 'Private' in UK English - follow up to 6872 #6890

Closed
LaurenWags opened this issue Nov 12, 2019 · 5 comments
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Nov 12, 2019

Description

Found while testing #6872

If you open a Private window while using UK English, the window doesn't say 'Private' any more.

Steps to Reproduce

  1. Using UK english, launch clean profile in a terminal
  2. Open Private Window

Actual result:

Screen Shot 2019-11-12 at 10 15 05 AM

Terminal errors:

[3184:3184:1112/181859.940022:ERROR:message_formatter.cc(91)] MessageFormat({0, plural,
      =1 {Private}
      other {{Private (#)}
    }) failed with U_PATTERN_SYNTAX_ERROR
[3184:3184:1112/181859.940473:ERROR:message_formatter.cc(91)] MessageFormat({0, plural,
      =1 {Private}
      other {{Private (#)}
    }) failed with U_PATTERN_SYNTAX_ERROR
[3184:3184:1112/181859.940575:ERROR:message_formatter.cc(91)] MessageFormat({0, plural,
      =1 {Private}
      other {{Private (#)}
    }) failed with U_PATTERN_SYNTAX_ERROR
[3184:3184:1112/181859.955558:ERROR:message_formatter.cc(91)] MessageFormat({0, plural,
      =1 {Private}
      other {{Private (#)}
    }) failed with U_PATTERN_SYNTAX_ERROR

Expected result:

No terminal errors
Screen Shot 2019-11-12 at 10 16 23 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @petemill

@kjozwiak
Copy link
Member

kjozwiak commented Nov 12, 2019

@rebron @bsclifton moving this into the 0.71.x milestone as we'll probably want this fixed before we release 0.71.x. It's a regression and might confuse new users who aren't as familiar with private windows/mode.

If you feel differently, please feel free to remove it from the milestone.

@btlechowski
Copy link

Reproduced on

Brave 0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

image

@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64- 0.71.115

image

@bsclifton
Copy link
Member

Fixed in 0.71 with brave/brave-core#3982

@LaurenWags
Copy link
Member Author

LaurenWags commented Nov 12, 2019

Verified passed with

Brave 0.71.116 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description.
  • No terminal errors were observed.

Screen Shot 2019-11-12 at 5 58 43 PM

Verification passed on

Brave 0.71.116 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description.
  • No terminal errors were observed.
    image

Verification passed on

Brave 0.71.116 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS
  • Verified STR from the description.
  • No terminal errors were observed.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment