Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAT Points follow-up to #6480 - Changes for Japan #6654

Closed
mandar-brave opened this issue Oct 29, 2019 · 5 comments
Closed

BAT Points follow-up to #6480 - Changes for Japan #6654

mandar-brave opened this issue Oct 29, 2019 · 5 comments

Comments

@mandar-brave
Copy link

mandar-brave commented Oct 29, 2019

Two changes that need to make it for the BAT Points fix;

a) All areas where we have text Tokens, needs to replaced with Points (search and replace)
b) Any BAT designation (tipping panel., etc.) needs to be replaced with BAP (Basic Attention Points)

see image below for b) ----
image

As example the Tip values in the panel would say 1.0 BAP, 5.0 BAP, and 10.0 BAP respectively

cc @jsecretan @NejcZdovc

@mandar-brave mandar-brave added bug feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. 1.0 labels Oct 29, 2019
@mattmcalister
Copy link

See spec doc for more details

@rebron rebron changed the title BAT Points - Changes for Japan BAT Points follow-up to #6480 - Changes for Japan Oct 30, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Oct 30, 2019

Running through brave/brave-core#3751 before approving the PR into 0.72.x and 0.71.x and noticed the following screens/areas using BAT as @mandar-brave mentioned above. Adding examples so it's easier to QA once this lands in Nightly and is ready for QA:

Tipping banner:

Screen Shot 2019-10-30 at 2 48 29 PM

Not enough funds during tipping banner:

Screen Shot 2019-10-30 at 5 58 58 PM

Confirmation banner once tip goes through:

Screen Shot 2019-10-30 at 2 48 59 PM

Confirmation banner once monthly tip has been set:

Screen Shot 2019-10-30 at 3 28 27 PM

Ads panel:

Screen Shot 2019-10-30 at 3 06 38 PM

Auto-contribution panel:

Screen Shot 2019-10-30 at 3 06 03 PM

Tipping panel under brave://rewards:

Screen Shot 2019-10-30 at 3 03 10 PM

Monthly contribution tipping panel:

Screen Shot 2019-10-30 at 3 28 17 PM

Join Rewards panel:

Screen Shot 2019-10-30 at 3 17 49 PM

Pending Contributions:

Screen Shot 2019-10-30 at 3 46 40 PM

Auto-Contribution Settings:

Screen Shot 2019-10-30 at 3 43 37 PM

Contribution Notification:

Screen Shot 2019-10-30 at 4 11 21 PM

Grant Notification:

Screen Shot 2019-10-30 at 5 50 49 PM

UGP grant confirmation:

Screen Shot 2019-10-30 at 21 02 13

@GeetaSarvadnya
Copy link

All the issues mentioned in the #6654 (comment) are reproduced in windows 10 x64 -0.71.111

ryanml added a commit to brave/brave-core that referenced this issue Nov 5, 2019
@ryanml ryanml added this to the 0.71.x - Release milestone Nov 5, 2019
ryanml added a commit to brave/brave-core that referenced this issue Nov 8, 2019
@bsclifton
Copy link
Member

Fixed in 0.71.x with brave/brave-core#3884

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 11, 2019

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Tipping Banner
image

No enough funds in tipping banner
image

Confirmation banner once tip goes through
image

Confirmation banner once the monthly tip has been set
image

Ads panel
image

Auto-contribution panel
image

Tipping panel under brave://rewards
image

Monthly contribution tipping panel
image

Join Rewards panel
image

Pending Contributions
image

Auto-Contribution Settings
image

Contribution Notification
image

image

Grant Notification
image

UGP grant confirmation
image

Verification PASSED on macOS 10.15.1 x64 using the following build:

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.15.1 (Build 19B88)

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants