-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BAT Points follow-up to #6480 - Changes for Japan #6654
Comments
See spec doc for more details |
Running through brave/brave-core#3751 before approving the PR into
|
All the issues mentioned in the #6654 (comment) are reproduced in windows 10 x64 - |
Fixed in 0.71.x with brave/brave-core#3884 |
Verification passed on
Verification PASSED on
Verification passed on
|
Two changes that need to make it for the BAT Points fix;
a) All areas where we have text Tokens, needs to replaced with Points (search and replace)
b) Any BAT designation (tipping panel., etc.) needs to be replaced with BAP (Basic Attention Points)
see image below for b) ----
As example the Tip values in the panel would say 1.0 BAP, 5.0 BAP, and 10.0 BAP respectively
cc @jsecretan @NejcZdovc
The text was updated successfully, but these errors were encountered: