Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untranslated text on connect hardware screen #6539

Closed
srirambv opened this issue Oct 18, 2019 · 5 comments
Closed

Untranslated text on connect hardware screen #6539

srirambv opened this issue Oct 18, 2019 · 5 comments

Comments

@srirambv
Copy link
Contributor

Description

Untranslated text on connect hardware screen

Steps to Reproduce

  1. Install component 0.1.17
  2. Connect hardware option from profile
  3. Connect Trezor with desktop, untranslated text show up

Actual result:

image

Expected result:

Should have all text translated

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Linux

Component 0.1.17

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Reproduced the issue 2 times on Trezor

@srirambv
Copy link
Contributor Author

Reproduced on Windows as well. Doesn't seem to be intermittent as I previously thought.
image

@srirambv
Copy link
Contributor Author

Steps to reproduce the issue

  • Create a wallet
  • Connect hardware
  • Select Trezor
  • Click connect, new tab opens to export public keys
  • Close the tab and go back to wallet page
  • Connect hardware page has the untranslated text

You can alternately use a VM and disconnect the USB device from VM to reproduce the issue

@srirambv srirambv changed the title [Intermittent] Untranslated text on connect hardware screen Untranslated text on connect hardware screen Oct 18, 2019
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Oct 25, 2019
@kjozwiak kjozwiak added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 22, 2019
@kjozwiak
Copy link
Member

Changing this to a P2. I think we need to fix sooner than later. You'll need to download the Trezor Bridge if you want to use the Trezor. The current UX flow is pretty confusing:

  • Connect to the Trezor and you'll be taken to https://wallet.trezor.io/
  • Click on Install Bridge and nothing happens but you'll be returned to brave://wallet and you'll notice the [object object] error.

@bbondy
Copy link
Member

bbondy commented Dec 20, 2019

@srirambv is this working now?

@srirambv
Copy link
Contributor Author

srirambv commented Feb 3, 2020

Verification passed on

Brave 1.5.76 Chromium: 80.0.3987.66 (Official Build) nightly (64-bit)
Revision 56ea77d65c47ecbb1180b99f860d85b51117864a-refs/branch-heads/3987@{#662}
OS Linux
Component 0.1.37
  • No untranslated text is shown on connect hardware screen
    image

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.1 (Build 19B88)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants