Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://brave.com/cryptocurrency-risk links to a 404 page #6485

Closed
srirambv opened this issue Oct 15, 2019 · 3 comments · Fixed by brave/ethereum-remote-client#83
Closed

Comments

@srirambv
Copy link
Contributor

Description

https://brave.com/cryptocurrency-risk isn't available which is linked to risk disclosure on disclaimer message

Actual result:

404 page not found

Expected result:

Link to an active page with proper content

Reproduces how often:

Easy

Brave version (brave://version info)

All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @bbondy @tomlowenthal @ryanml

@srirambv srirambv added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support labels Oct 15, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Oct 15, 2019

Example of where the link is being displayed as @btlechowski @GeetaSarvadnya and @LaurenWags haven't QA'd Crypto Wallets so they might now know where the location of the links are. Also might help developers:

Screen Shot 2019-10-15 at 4 12 57 PM

Screen Shot 2019-10-15 at 4 11 41 PM

@tomlowenthal do you know if there's any other locations where a link to https://brave.com/cryptocurrency-risk might be displayed?

@srirambv
Copy link
Contributor Author

Should be on

  • Create wallet page
  • Restore wallet page

@srirambv
Copy link
Contributor Author

srirambv commented Oct 17, 2019

Verification passed on

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Linux
  • Verification passed on component 1.0.11
  • Verified updated disclosure text on first launch
    image
  • Verified risk disclosure text/link is not shown on create wallet page
    image
  • Verified risk disclosure text/link is not shown on restore wallet page
    image

Verification passed on

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Windows
  • Verification passed on component 1.0.11
  • Verified updated disclosure text on first launch
    image
  • Verified risk disclosure text/link is not shown on create wallet page
    image
  • Verified risk disclosure text/link is not shown on restore wallet page
    image

Verification passed on

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS macOS Version 10.14.6 (Build 18G103)
  • Verification passed on component 1.0.11
  • Verified updated disclosure text on first launch

Screen Shot 2019-10-18 at 8 45 08 AM

  • Verified risk disclosure text/link is not shown on create wallet page

Screen Shot 2019-10-18 at 8 45 19 AM

  • Verified risk disclosure text/link is not shown on restore wallet page

Screen Shot 2019-10-18 at 8 45 43 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants