Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uphold old logo is used #6202

Closed
btlechowski opened this issue Sep 27, 2019 · 2 comments
Closed

Uphold old logo is used #6202

btlechowski opened this issue Sep 27, 2019 · 2 comments

Comments

@btlechowski
Copy link

btlechowski commented Sep 27, 2019

Follow up to #5876

Note: The PR was uplifted to 0.69.x and it should be fixed in 0.69.129 per commit history(Commit desc: Uplift of #3447). But we still use old uphold logo.

Steps to Reproduce

  1. Link your KYCed uphold account to Brave
  2. Go to brave://rewards
  3. Click on Wallet Verified

Actual result:

Old logo is used

image

image

Also old logo is shown when trying to verify wallet
image

Expected result:

New uphold logo is shown per #5876
img-uphold-logo

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @NejcZdovc @ryanml @rebron @jenn-rhim

@btlechowski btlechowski added design A design change, especially one which needs input from the design team feature/rewards QA/Yes QA/Test-Plan-Specified labels Sep 27, 2019
@btlechowski
Copy link
Author

It seems that there was another uplift done after 0.69.129 (Merge pull request #3488 from brave/pr-3447-uplift).

Closing as the issue was addressed.

@btlechowski
Copy link
Author

btlechowski commented Sep 28, 2019

Verification passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

brave://rewards page
image
image
Brave Rewards Panel
image
brave://rewards/#verify
image

Verified passed with

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Verification passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants