Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of whitespace on www.dia.net.au #6190

Closed
btlechowski opened this issue Sep 26, 2019 · 6 comments
Closed

Lots of whitespace on www.dia.net.au #6190

btlechowski opened this issue Sep 26, 2019 · 6 comments

Comments

@btlechowski
Copy link

Follow up to: #4338
Original report: https://community.brave.com/t/page-rendering-issue/58045

Steps to Reproduce

  1. Open www.dia.net.au

Actual result:

image

Note: the white space is where ads used to be.

Expected result:

No white space

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

cc @Brave-Matt @brave/legacy_qa

@kjozwiak
Copy link
Member

Reproducible on macOS 10.14.6 x64 as well using the following build:

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

Screen Shot 2019-09-26 at 8 09 21 PM

@GeetaSarvadnya
Copy link

Reproducible in Windows 10 x64 - 0.69.129

image

@ryanbr
Copy link

ryanbr commented Sep 30, 2019

fanboy@ubunutu:~/git/easylist/easylist$ grep -r 728x90.png *
easylist_general_block_dimensions.txt:728x90.png|

Which does block the https://www.dia.net.au/wp-content/uploads/2018/09/DreamsIntoAction728x90.png But not sure whats causing the whitespace issue.

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Oct 4, 2019
@ryanbr
Copy link

ryanbr commented Mar 8, 2020

Seems the site is fine, @btlechowski can you confirm Brave Release is rendering this site okay? No obvious whitespace issues.

@ryanbr
Copy link

ryanbr commented Mar 14, 2020

Re-testing before closing. Tested in Brave Release/Beta and Nightly. No more space issues @btlechowski

Re-open ticket if I've missed something, but it seems fine now.

@ryanbr ryanbr closed this as completed Mar 14, 2020
@btlechowski
Copy link
Author

btlechowski commented Mar 24, 2020

Verification passed on

Brave 1.7.70 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image


Verified passed with

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified steps from description

Screen Shot 2020-03-24 at 10 21 27 AM

Verification passed on

Brave 1.7.74 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified steps from the description
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants