Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing "Cancel" & "Save" buttons for ETH networks that have already been created and can't be edited #6161

Closed
kjozwiak opened this issue Sep 25, 2019 · 3 comments · Fixed by brave/ethereum-remote-client#74

Comments

@kjozwiak
Copy link
Member

Description

When going into brave://wallet --> Settings --> Networks, you'll notice that there's Cancel & Save buttons for each network that's already created by default. However, you can't edit those networks. We should only be displaying Cancel & Save for custom networks that have been added by going through Add Network.

Steps to Reproduce

  1. launch 0.69.128 CR: 77.0.3865.75 and open brave://wallet
  2. click on Create under New Local Wallet
  3. enter your password and click on Remind me later under Secret Backup Phrase
  4. click on the My Accounts avatar --> Settings --> Networks

You'll notice Cancel & Save buttons that can't be used for the networks that have already been created.

Actual result:

Screen Shot 2019-09-24 at 11 49 20 PM

Expected result:

Shouldn't be displaying Cancel & Save buttons for the networks that have already been created as you cannot edit them.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS macOS Version 10.14.6 (Build 18G95)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A (technically not released)
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @brave/legacy_qa

@bbondy
Copy link
Member

bbondy commented Oct 1, 2019

can we upstream too?

@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Oct 2, 2019
@bbondy bbondy added this to the Ethereum Remote Client 1.0.10 milestone Oct 7, 2019
@kjozwiak
Copy link
Member Author

kjozwiak commented Oct 7, 2019

Verification PASSED on macOS 10.14.6 x64 using https://github.com/brave/ethereum-remote-client/releases/tag/1.0.10 via the following build:

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)
  • ensured that you can't edit/remove the default networks from Settings -> Networks
  • ensured that you can create/edit and delete a custom network

Screen Shot 2019-10-07 at 1 43 23 PM

Screen Shot 2019-10-07 at 1 42 53 PM

Screen Shot 2019-10-07 at 1 45 17 PM

Verification PASSED on Win 10 x64 using https://github.com/brave/ethereum-remote-client/releases/tag/1.0.10 via the following build:

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1809 (Build 17763.737)
  • ensured that you can't edit/remove the default networks from Settings -> Networks
  • ensured that you can create/edit and delete a custom network

Annotation 2019-10-07 135527

Annotation 2019-10-07 135500

Annotation 2019-10-07 135641

@srirambv
Copy link
Contributor

srirambv commented Oct 8, 2019

Verification passed on

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux
  • Verified existing pre-loaded networks can't be edited using 1.0.10 via sideload
  • Verified new network added can be saved/edited/deleted
    image
    image

@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment