Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask icons in connect hardware screen #6038

Closed
srirambv opened this issue Sep 16, 2019 · 4 comments · Fixed by brave/ethereum-remote-client#84
Closed

Metamask icons in connect hardware screen #6038

srirambv opened this issue Sep 16, 2019 · 4 comments · Fixed by brave/ethereum-remote-client#84

Comments

@srirambv
Copy link
Contributor

Description

Metamask icons in connect hardware screen

Steps to Reproduce

  1. Create account on Crypto Wallet
  2. Go to profile and connect hardware
  3. Connect hardware screen uses Metamask icons in welcome screen

Actual result:

image

Expected result:

Should use Brave branding

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.70.93 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

cc: @jamesmudgett

@ryanml
Copy link
Contributor

ryanml commented Sep 21, 2019

cc: @jamesmudgett for replacement iconography

@bbondy
Copy link
Member

bbondy commented Oct 2, 2019

ping @jamesmudgett

@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 2, 2019
@jamesmudgett
Copy link

Replacements attached
Artboard

Archive.zip

@srirambv
Copy link
Contributor Author

srirambv commented Oct 17, 2019

Verification passed on

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Linux
  • Verification passed on component 0.1.17
    image

Verification passed on

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Windows 10 OS Version 1903 (Build 18362.388)
  • Verification passed on component 0.1.17
    image

Verification passed on

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS macOS Version 10.14.6 (Build 18G103)
  • Verification passed on component 0.1.17

Screen Shot 2019-10-18 at 8 52 11 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants