Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create wallet spinner on panel doesn't show on second monitor #5990

Closed
LaurenWags opened this issue Sep 11, 2019 · 4 comments
Closed

create wallet spinner on panel doesn't show on second monitor #5990

LaurenWags opened this issue Sep 11, 2019 · 4 comments

Comments

@LaurenWags
Copy link
Member

Description

When joining Rewards from the panel, the 'Join Rewards' button should turn to 'Creating wallet' button with a spinner. This happens on my main laptop screen with both 0.68.132 (C76) and 0.68.134 (C77). However, if I do this on my second monitor, the button does not change when using 0.68.134.

Steps to Reproduce

  1. Using a second monitor, launch a clean profile with 0.68.134
  2. Click on panel
  3. Click on Join Rewards

Actual result:

Button text does not change, spinner does not show:
createwalletspinner-068134

Expected result:

Behaves as it does in 0.68.132:
createwalletspinner-068132

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.68.134 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 0.68.132, no 0.68.134 yes
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@LaurenWags
Copy link
Member Author

cc @bsclifton @rebron since related to c77

@NejcZdovc
Copy link
Contributor

not sure what could be done here. Is some kind render change happened in 77?

@NejcZdovc NejcZdovc added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Sep 12, 2019
@NejcZdovc
Copy link
Contributor

@LaurenWags still a problem?

@NejcZdovc NejcZdovc added needs-more-info The report requires more detail before we can decide what to do with this issue. and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Apr 10, 2020
@LaurenWags
Copy link
Member Author

no longer an issue. closing this one.

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Apr 10, 2020
@NejcZdovc NejcZdovc added closed/not-actionable and removed QA/Test-Plan-Specified QA/Yes needs-more-info The report requires more detail before we can decide what to do with this issue. regression labels Apr 10, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants