Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent connections to translate.googleapis.com #5829

Closed
jonathansampson opened this issue Aug 28, 2019 · 1 comment · Fixed by brave/brave-core#3293
Closed

Prevent connections to translate.googleapis.com #5829

jonathansampson opened this issue Aug 28, 2019 · 1 comment · Fixed by brave/brave-core#3293

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Aug 28, 2019

Description

Brave proxies many requests, but one may have slipped by.

Steps to Reproduce

  1. Use little snitch/Fiddle or similar tools to observe connections made by Brave browser
  2. Launch Brave from a new profile
  3. Visit brave://settings

Actual result:

Brave contacts translate.googleapis.com

Expected result:

Brave contacts translate.brave.com (if any connection is necessary to begin with)

Reproduces how often:

Always (on a fresh profile)

Brave version (brave://version info)

0.69.113

Miscellaneous Information:

image

@kjozwiak
Copy link
Member

kjozwiak commented Sep 4, 2019

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.122 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X
  • Reproduced the original issue using 0.69.119

Screen Shot 2019-09-03 at 10 00 25 PM

  • Verified that going into brave://settings doesn't contact translate.googleapis.com:

Screen Shot 2019-09-03 at 10 10 45 PM

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Reproduced the original issue using 0.69.119

image

  • Verified that going into brave://settings doesn't contact translate.googleapis.com:

image

  • Verified that On startup, connections are not made to google
  1. http://safebrowsing.brave.com/
  2. http://static.brave.com/
  3. http://laptop-updates.brave.com/
  4. http://go-updater.brave.com/
  5. http://componentupdater.brave.com/
  6. http://crlsets.brave.com/
  7. http://brave-core-ext.s3.brave.com/

Verification passed on

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
  • Verified that going into brave://settings doesn't contact translate.googleapis.com
  • Verified that On startup, connections are not made to google
  1. http://safebrowsing.brave.com/
  2. http://static.brave.com/
  3. http://laptop-updates.brave.com/
  4. http://go-updater.brave.com/
  5. http://componentupdater.brave.com/
  6. http://crlsets.brave.com/
  7. http://brave-core-ext.s3.brave.com/

@rebron rebron changed the title Brave connects to translate.googleapis.com Prevent connections to translate.googleapis.com Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants