Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields: move components from brave-ui to brave-core #5505

Closed
cezaraugusto opened this issue Aug 1, 2019 · 0 comments · Fixed by brave/brave-core#2944
Closed

Shields: move components from brave-ui to brave-core #5505

cezaraugusto opened this issue Aug 1, 2019 · 0 comments · Fixed by brave/brave-core#2944
Assignees
@cezaraugusto
Labels
dev-experience feature/shields/panel Front-end design and functionality of the Shields panel. QA/Yes release-notes/exclude
Milestone
Closed / Dupe / I...

Comments

@cezaraugusto
Copy link
Contributor

(details here adapted originally from #5178)

Shields components are specific to brave-core. It will be more productive to have these inside the brave-core repo rather than in a separate repo (brave-ui).

Reasoning and steps explained in #2335

Test Plan

  • Open Shields
  • Check renders and no console errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
dev-experience feature/shields/panel Front-end design and functionality of the Shields panel. QA/Yes release-notes/exclude
Projects
None yet
Milestone
Closed / Dupe / Invalid
Development

Successfully merging a pull request may close this issue.

Brave Extension (Shields): Move from brave-ui to brave-core brave/brave-core
2 participants
@bbondy @cezaraugusto